From: "Doug Kwan (關振德)" <dougkwan@google.com>
To: "Michael Snyder" <msnyder@specifix.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdbserver] Check for sys/dir.h and sys.user.h in configuration.
Date: Wed, 23 Jul 2008 08:29:00 -0000 [thread overview]
Message-ID: <498552560807230129l68c77f83j972288065be91b45@mail.gmail.com> (raw)
In-Reply-To: <1216784910.3549.496.camel@localhost.localdomain>
Hi,
2008/7/22 Michael Snyder <msnyder@specifix.com>:
> I'm surprised by some of the diffs in the generated configure
> script -- wonder if you used a different version of autoconf
> or something?
I don't know. My autoconf claims to be 2.59 and the original
configure is generated by autoconf 2.59 also.
> Otherwise looks pretty OK.
> I don't know enough to say whether STDC_HEADERS is the right
> ifdef for the errno change in linux_write_memory.
This is done in gdbreplay.c also. I assume that's the correct way to
do it. But it's moot now as another reviewer suggests removing the
declaration altogether.
-Doug
next prev parent reply other threads:[~2008-07-23 8:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 1:00 Doug Kwan (關振德)
2008-07-23 3:49 ` Michael Snyder
2008-07-23 8:29 ` Doug Kwan (關振德) [this message]
2008-07-23 14:15 ` Thiago Jung Bauermann
2008-07-23 14:33 ` Daniel Jacobowitz
2008-07-23 17:15 ` Doug Kwan (關振德)
2008-07-25 21:42 ` Daniel Jacobowitz
2008-07-25 22:54 ` Doug Kwan (關振德)
2008-07-25 23:02 ` Doug Kwan (關振德)
2008-07-25 21:35 ` Doug Kwan (關振德)
2008-07-23 7:57 ` Andreas Schwab
2008-07-23 8:33 ` Doug Kwan (關振德)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498552560807230129l68c77f83j972288065be91b45@mail.gmail.com \
--to=dougkwan@google.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@specifix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox