From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 856 invoked by alias); 23 Jul 2008 08:29:57 -0000 Received: (qmail 845 invoked by uid 22791); 23 Jul 2008 08:29:56 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 23 Jul 2008 08:29:39 +0000 Received: from wpaz1.hot.corp.google.com (wpaz1.hot.corp.google.com [172.24.198.65]) by smtp-out3.google.com with ESMTP id m6N8TYhh031717 for ; Wed, 23 Jul 2008 09:29:35 +0100 Received: from rv-out-0506.google.com (rvfb25.prod.google.com [10.140.179.25]) by wpaz1.hot.corp.google.com with ESMTP id m6N8TXNk032403 for ; Wed, 23 Jul 2008 01:29:34 -0700 Received: by rv-out-0506.google.com with SMTP id b25so1910211rvf.49 for ; Wed, 23 Jul 2008 01:29:33 -0700 (PDT) Received: by 10.141.79.12 with SMTP id g12mr435918rvl.126.1216801773327; Wed, 23 Jul 2008 01:29:33 -0700 (PDT) Received: by 10.140.248.15 with HTTP; Wed, 23 Jul 2008 01:29:33 -0700 (PDT) Message-ID: <498552560807230129l68c77f83j972288065be91b45@mail.gmail.com> Date: Wed, 23 Jul 2008 08:29:00 -0000 From: "=?BIG5?B?RG91ZyBLd2FuICjD9q62vHcp?=" To: "Michael Snyder" Subject: Re: [PATCH][gdbserver] Check for sys/dir.h and sys.user.h in configuration. Cc: gdb-patches@sourceware.org In-Reply-To: <1216784910.3549.496.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <498552560807221759w1ade0ec2jd63c12475ddb5217@mail.gmail.com> <1216784910.3549.496.camel@localhost.localdomain> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00411.txt.bz2 Hi, 2008/7/22 Michael Snyder : > I'm surprised by some of the diffs in the generated configure > script -- wonder if you used a different version of autoconf > or something? I don't know. My autoconf claims to be 2.59 and the original configure is generated by autoconf 2.59 also. > Otherwise looks pretty OK. > I don't know enough to say whether STDC_HEADERS is the right > ifdef for the errno change in linux_write_memory. This is done in gdbreplay.c also. I assume that's the correct way to do it. But it's moot now as another reviewer suggests removing the declaration altogether. -Doug