Re: [PATCH][gdbserver] Check for sys/dir.h and sys.user.h in configuration.

[Daniel Jacobowitz <drow@false.org>]

On Wed, Jul 23, 2008 at 10:14:52AM -0700, Doug Kwan (關振德) wrote:
> I used the autoconf-2.59.tar.bz2 from ftp.gnu.org. I got fewer spurios
> diffs than before but there still seems to be some left.  Here is an
> updated patch.
> 
> -Doug
> 
> 2008-07-23  Doug Kwan  <dougkwan@google.com>
> 
>         * configure.ac: Check for sys/dir.h and sys.user.h.
>         * config.in configure: Regenerate.
>         * linux-low.c: Include <sys/dir.h> if HAVE_SYS_DIR_H is defined.
>         Include <sys/user.h> if HAVE_SYS_USER_H is defined.
>         (linux_write_memory): Remove declaration of errno.

Just one question: if removing sys/user.h and sys/dir.h doesn't break
anything on android, does it break anything on other GNU/Linux
targets?

Removing the errno declaration is fine.  Removing the includes is fine
if they're not actually necessary, otherwise this patch is OK.

-- 
Daniel Jacobowitz
CodeSourcery