From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2369 invoked by alias); 25 Jul 2008 21:42:19 -0000 Received: (qmail 2348 invoked by uid 22791); 25 Jul 2008 21:42:17 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 25 Jul 2008 21:41:46 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 647C998215; Fri, 25 Jul 2008 21:41:44 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id F2D7E9809F; Fri, 25 Jul 2008 21:41:43 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KMV2k-0004pD-U3; Fri, 25 Jul 2008 17:41:42 -0400 Date: Fri, 25 Jul 2008 21:42:00 -0000 From: Daniel Jacobowitz To: Doug Kwan =?utf-8?B?KOmXnOaMr+W+tyk=?= Cc: Thiago Jung Bauermann , Michael Snyder , gdb-patches@sourceware.org Subject: Re: [PATCH][gdbserver] Check for sys/dir.h and sys.user.h in configuration. Message-ID: <20080725214142.GA18480@caradoc.them.org> Mail-Followup-To: Doug Kwan =?utf-8?B?KOmXnOaMr+W+tyk=?= , Thiago Jung Bauermann , Michael Snyder , gdb-patches@sourceware.org References: <498552560807221759w1ade0ec2jd63c12475ddb5217@mail.gmail.com> <1216784910.3549.496.camel@localhost.localdomain> <1216821712.5922.8.camel@localhost.localdomain> <20080723143258.GA12421@caradoc.them.org> <498552560807231014q317b59bai907c4cf9f9009f6e@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <498552560807231014q317b59bai907c4cf9f9009f6e@mail.gmail.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00458.txt.bz2 On Wed, Jul 23, 2008 at 10:14:52AM -0700, Doug Kwan (關振德) wrote: > I used the autoconf-2.59.tar.bz2 from ftp.gnu.org. I got fewer spurios > diffs than before but there still seems to be some left. Here is an > updated patch. > > -Doug > > 2008-07-23 Doug Kwan > > * configure.ac: Check for sys/dir.h and sys.user.h. > * config.in configure: Regenerate. > * linux-low.c: Include if HAVE_SYS_DIR_H is defined. > Include if HAVE_SYS_USER_H is defined. > (linux_write_memory): Remove declaration of errno. Just one question: if removing sys/user.h and sys/dir.h doesn't break anything on android, does it break anything on other GNU/Linux targets? Removing the errno declaration is fine. Removing the includes is fine if they're not actually necessary, otherwise this patch is OK. -- Daniel Jacobowitz CodeSourcery