[RFA] Darwin Port (Part 1: changes in common files)

[RFA] Darwin Port (Part 1: changes in common files)

[Tristan Gingold]

diff -c -r1.101 configure.host
*** configure.host	19 Jan 2008 15:03:50 -0000	1.101
--- configure.host	10 Nov 2008 10:19:14 -0000
***************
*** 62,67 ****
--- 62,69 ----

   case "${host}" in

+ *-apple-darwin*)	gdb_host=macosx ;;
+
   alpha*-*-osf[3456789]*)	gdb_host=alpha-osf3 ;;
   alpha*-*-linux*)	gdb_host=alpha-linux ;;
   alpha*-*-freebsd* | alpha*-*-kfreebsd*-gnu)
Index: configure.tgt
===================================================================
RCS file: /cvs/src/src/gdb/configure.tgt,v
retrieving revision 1.204
diff -c -r1.204 configure.tgt
*** configure.tgt	2 Oct 2008 15:48:06 -0000	1.204
--- configure.tgt	10 Nov 2008 10:19:15 -0000
***************
*** 145,150 ****
--- 145,155 ----
   	gdb_target_obs="hppa-tdep.o"
   	;;

+ i[34567]86-*-darwin*)
+ 	# Target: Darwin/i386
+ 	gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o \
+ 			i386-macosx-tdep.o"
+ 	;;
   i[34567]86-*-dicos*)
   	# Target: DICOS/i386
   	gdb_target_obs="i386-tdep.o i387-tdep.o \
Index: defs.h
===================================================================
RCS file: /cvs/src/src/gdb/defs.h,v
retrieving revision 1.241
diff -c -r1.241 defs.h
*** defs.h	5 Nov 2008 20:23:07 -0000	1.241
--- defs.h	10 Nov 2008 10:19:15 -0000
***************
*** 958,963 ****
--- 958,966 ----
     GDB_OSABI_AIX,
     GDB_OSABI_DICOS,

+   GDB_OSABI_DARWIN,
+   GDB_OSABI_DARWIN64,
+
     GDB_OSABI_INVALID		/* keep this last */
   };

Index: osabi.c
===================================================================
RCS file: /cvs/src/src/gdb/osabi.c,v
retrieving revision 1.43
diff -c -r1.43 osabi.c
*** osabi.c	1 May 2008 23:09:14 -0000	1.43
--- osabi.c	10 Nov 2008 10:19:15 -0000
***************
*** 73,78 ****
--- 73,80 ----
     "Cygwin",
     "AIX",
     "DICOS",
+   "Darwin",
+   "Darwin64",

     "<invalid>"
   };

Re: [RFA] Darwin Port (Part 1: changes in common files)

[Mark Kettenis]

> From: Tristan Gingold <gingold@adacore.com>
> Date: Mon, 10 Nov 2008 11:20:41 +0100
> 
> diff -c -r1.101 configure.host
> *** configure.host	19 Jan 2008 15:03:50 -0000	1.101
> --- configure.host	10 Nov 2008 10:19:14 -0000
> ***************
> *** 62,67 ****
> --- 62,69 ----
> 
>    case "${host}" in
> 
> + *-apple-darwin*)	gdb_host=macosx ;;
> +
>    alpha*-*-osf[3456789]*)	gdb_host=alpha-osf3 ;;
>    alpha*-*-linux*)	gdb_host=alpha-linux ;;
>    alpha*-*-freebsd* | alpha*-*-kfreebsd*-gnu)

I know Apple doesn't want you to run their OS on non-Apple hardware,
but I don't think we should reinforce that standpoint.  Could we just
match *-*-dawrwin*?

Also, I'm a bit confused by the Darwin vs. MacOS X naming game.  I
realize it would be quite a bit of work, but to me it would make sense
to exclusively use Darwin in comments, function names and file names
(appropriately capitalized).

> Index: configure.tgt
> ===================================================================
> RCS file: /cvs/src/src/gdb/configure.tgt,v
> retrieving revision 1.204
> diff -c -r1.204 configure.tgt
> *** configure.tgt	2 Oct 2008 15:48:06 -0000	1.204
> --- configure.tgt	10 Nov 2008 10:19:15 -0000
> ***************
> *** 145,150 ****
> --- 145,155 ----
>    	gdb_target_obs="hppa-tdep.o"
>    	;;
> 
> + i[34567]86-*-darwin*)
> + 	# Target: Darwin/i386
> + 	gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o \
> + 			i386-macosx-tdep.o"
> + 	;;
>    i[34567]86-*-dicos*)
>    	# Target: DICOS/i386
>    	gdb_target_obs="i386-tdep.o i387-tdep.o \
> Index: defs.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/defs.h,v
> retrieving revision 1.241
> diff -c -r1.241 defs.h
> *** defs.h	5 Nov 2008 20:23:07 -0000	1.241
> --- defs.h	10 Nov 2008 10:19:15 -0000
> ***************
> *** 958,963 ****
> --- 958,966 ----
>      GDB_OSABI_AIX,
>      GDB_OSABI_DICOS,
> 
> +   GDB_OSABI_DARWIN,
> +   GDB_OSABI_DARWIN64,
> +
>      GDB_OSABI_INVALID		/* keep this last */
>    };

Why do you need both Darwin and Darwin64?  We don't do this for other
operating systems that have both a 32-bit and a 64-bit variant.

Re: [RFA] Darwin Port (Part 1: changes in common files)

[Stan Shebs]

Mark Kettenis wrote:
>> From: Tristan Gingold <gingold@adacore.com>
>> Date: Mon, 10 Nov 2008 11:20:41 +0100
>>
>> diff -c -r1.101 configure.host
>> *** configure.host	19 Jan 2008 15:03:50 -0000	1.101
>> --- configure.host	10 Nov 2008 10:19:14 -0000
>> ***************
>> *** 62,67 ****
>> --- 62,69 ----
>>
>>    case "${host}" in
>>
>> + *-apple-darwin*)	gdb_host=macosx ;;
>> +
>>    alpha*-*-osf[3456789]*)	gdb_host=alpha-osf3 ;;
>>    alpha*-*-linux*)	gdb_host=alpha-linux ;;
>>    alpha*-*-freebsd* | alpha*-*-kfreebsd*-gnu)
>>     
>
> I know Apple doesn't want you to run their OS on non-Apple hardware,
> but I don't think we should reinforce that standpoint.  Could we just
> match *-*-darwin*?
>   
I agree.
> Also, I'm a bit confused by the Darwin vs. MacOS X naming game.  I
> realize it would be quite a bit of work, but to me it would make sense
> to exclusively use Darwin in comments, function names and file names
> (appropriately capitalized).
>   
Yes, we should be using "Darwin" everywhere in sources, file names, etc. 
"Mac OS X" refers to the total package that Apple delivers, with Aqua, 
Finder, etc, while Darwin is kernel + Unix-style tools. Darwin is fully 
functional by itself, and to the casual user would look nearly identical 
to FreeBSD. There shouldn't be anything in FSF GDB that depends on 
non-Darwin OS X bits; there wasn't anything like that in Apple's GDB 
either, at least in the past. (Apple's GDB is inconsistent about 
"darwin" vs "macosx", not least because it predates the creation of the 
Darwin project.)
> Why do you need both Darwin and Darwin64?  We don't do this for other
> operating systems that have both a 32-bit and a 64-bit variant.
>
>   
This may or may not be necessary - the ABIs are different, and both 
32-bit and 64-bit executables can be run at the same time by the same 
kernel, no rebooting needed. So a GDB session does have to distinguish 
the two types of executables.

Stan

Re: [RFA] Darwin Port (Part 1: changes in common files)

[Mark Kettenis]

> Date: Mon, 10 Nov 2008 12:07:06 -0800
> From: Stan Shebs <stanshebs@earthlink.net>
> 
> Mark Kettenis wrote:
> > Why do you need both Darwin and Darwin64?  We don't do this for other
> > operating systems that have both a 32-bit and a 64-bit variant.
> >
> >   
> This may or may not be necessary - the ABIs are different, and both 
> 32-bit and 64-bit executables can be run at the same time by the same 
> kernel, no rebooting needed. So a GDB session does have to distinguish 
> the two types of executables.

That's no different from Linux or FreeBSD or NetBSD.  Those systems
will happily run 32-bit and 64-bit executables alongside eachother (as
long as you are running a 64-bit kernel).

Re: [RFA] Darwin Port (Part 1: changes in common files)

[Joel Brobecker]

Hey Mark,

Thanks much for taking a look at the patches!

> I know Apple doesn't want you to run their OS on non-Apple hardware,
> but I don't think we should reinforce that standpoint.  Could we just
> match *-*-dawrwin*?

I agree as well.

> > +   GDB_OSABI_DARWIN,
> > +   GDB_OSABI_DARWIN64,
> > +
> >      GDB_OSABI_INVALID		/* keep this last */
> >    };
> 
> Why do you need both Darwin and Darwin64?  We don't do this for other
> operating systems that have both a 32-bit and a 64-bit variant.

I looked at the way we do things, and I think that it simplifies
the code a little. But I also think that it should be possible do
without - this seems like a reasonable request, given that this
would be consistent will all the other 32+64bit architectures.

-- 
Joel

Re: [RFA] Darwin Port (Part 1: changes in common files)

[Mark Kettenis]

> Date: Mon, 10 Nov 2008 15:01:17 -0800
> From: Joel Brobecker <brobecker@adacore.com>
> 
> > > +   GDB_OSABI_DARWIN,
> > > +   GDB_OSABI_DARWIN64,
> > > +
> > >      GDB_OSABI_INVALID		/* keep this last */
> > >    };
> > 
> > Why do you need both Darwin and Darwin64?  We don't do this for other
> > operating systems that have both a 32-bit and a 64-bit variant.
> 
> I looked at the way we do things, and I think that it simplifies
> the code a little. But I also think that it should be possible do
> without - this seems like a reasonable request, given that this
> would be consistent will all the other 32+64bit architectures.

Yes, that is indeed my concern.  Doing things in a similar way to
other architectures makes things easier to maintain.

Re: [RFA] Darwin Port (Part 1: changes in common files)

[Tristan Gingold]

On Nov 10, 2008, at 7:58 PM, Mark Kettenis wrote:
> I know Apple doesn't want you to run their OS on non-Apple hardware,
> but I don't think we should reinforce that standpoint.  Could we just
> match *-*-dawrwin*?

Sure!  Note that you can run darwin on any hardware (as it is open  
source)

> Also, I'm a bit confused by the Darwin vs. MacOS X naming game.  I
> realize it would be quite a bit of work, but to me it would make sense
> to exclusively use Darwin in comments, function names and file names
> (appropriately capitalized).

Ok, not fun but better earlier than later.

> Why do you need both Darwin and Darwin64?  We don't do this for other
> operating systems that have both a 32-bit and a 64-bit variant.

Ok, will learn how to do with only one osabi.

Tristan.