From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-59794-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3634 invoked by alias); 10 Nov 2008 18:59:33 -0000
Received: (qmail 3608 invoked by uid 22791); 10 Nov 2008 18:59:32 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 10 Nov 2008 18:58:56 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id mAAIwo1K029493; 	Mon, 10 Nov 2008 19:58:50 +0100 (CET)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id mAAIwoKj009428; 	Mon, 10 Nov 2008 19:58:50 +0100 (CET)
Date: Mon, 10 Nov 2008 19:37:00 -0000
Message-Id: <200811101858.mAAIwoKj009428@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: gingold@adacore.com
CC: gdb-patches@sourceware.org
In-reply-to: <6C04CB59-A202-4D7E-B2DA-97DAE3F3ED85@adacore.com> (message from 	Tristan Gingold on Mon, 10 Nov 2008 11:20:41 +0100)
Subject: Re: [RFA] Darwin Port (Part 1: changes in common files)
References:  <6C04CB59-A202-4D7E-B2DA-97DAE3F3ED85@adacore.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-11/txt/msg00185.txt.bz2

> From: Tristan Gingold <gingold@adacore.com>
> Date: Mon, 10 Nov 2008 11:20:41 +0100
> 
> diff -c -r1.101 configure.host
> *** configure.host	19 Jan 2008 15:03:50 -0000	1.101
> --- configure.host	10 Nov 2008 10:19:14 -0000
> ***************
> *** 62,67 ****
> --- 62,69 ----
> 
>    case "${host}" in
> 
> + *-apple-darwin*)	gdb_host=macosx ;;
> +
>    alpha*-*-osf[3456789]*)	gdb_host=alpha-osf3 ;;
>    alpha*-*-linux*)	gdb_host=alpha-linux ;;
>    alpha*-*-freebsd* | alpha*-*-kfreebsd*-gnu)

I know Apple doesn't want you to run their OS on non-Apple hardware,
but I don't think we should reinforce that standpoint.  Could we just
match *-*-dawrwin*?

Also, I'm a bit confused by the Darwin vs. MacOS X naming game.  I
realize it would be quite a bit of work, but to me it would make sense
to exclusively use Darwin in comments, function names and file names
(appropriately capitalized).

> Index: configure.tgt
> ===================================================================
> RCS file: /cvs/src/src/gdb/configure.tgt,v
> retrieving revision 1.204
> diff -c -r1.204 configure.tgt
> *** configure.tgt	2 Oct 2008 15:48:06 -0000	1.204
> --- configure.tgt	10 Nov 2008 10:19:15 -0000
> ***************
> *** 145,150 ****
> --- 145,155 ----
>    	gdb_target_obs="hppa-tdep.o"
>    	;;
> 
> + i[34567]86-*-darwin*)
> + 	# Target: Darwin/i386
> + 	gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o \
> + 			i386-macosx-tdep.o"
> + 	;;
>    i[34567]86-*-dicos*)
>    	# Target: DICOS/i386
>    	gdb_target_obs="i386-tdep.o i387-tdep.o \
> Index: defs.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/defs.h,v
> retrieving revision 1.241
> diff -c -r1.241 defs.h
> *** defs.h	5 Nov 2008 20:23:07 -0000	1.241
> --- defs.h	10 Nov 2008 10:19:15 -0000
> ***************
> *** 958,963 ****
> --- 958,966 ----
>      GDB_OSABI_AIX,
>      GDB_OSABI_DICOS,
> 
> +   GDB_OSABI_DARWIN,
> +   GDB_OSABI_DARWIN64,
> +
>      GDB_OSABI_INVALID		/* keep this last */
>    };

Why do you need both Darwin and Darwin64?  We don't do this for other
operating systems that have both a 32-bit and a 64-bit variant.