* [reverse RFA] Change "record-auto-delete" to "record-stop-at-limit"
@ 2008-10-15 8:09 teawater
2008-10-15 18:46 ` Michael Snyder
0 siblings, 1 reply; 3+ messages in thread
From: teawater @ 2008-10-15 8:09 UTC (permalink / raw)
To: gdb-patches, Michael Snyder
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
Hi Michael,
According to Eli's suggest, Change "record-auto-delete" to
"record-stop-at-limit".
2008-10-15 Hui Zhu <teawater@gmail.com>
Change "record-auto-delete" to "record-stop-at-limit".
* record.c (record_insn_max_mode): Change to
"record_stop_at_limit".
(record_check_insn_num): Ditto.
(_initialize_record): Ditto.
Thanks,
Hui
[-- Attachment #2: change-record-auto-delete.txt --]
[-- Type: text/plain, Size: 2764 bytes --]
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2008-10-15 Hui Zhu <teawater@gmail.com>
+
+ Change "record-auto-delete" to "record-stop-at-limit".
+
+ * record.c (record_insn_max_mode): Change to
+ "record_stop_at_limit".
+ (record_check_insn_num): Ditto.
+ (_initialize_record): Ditto.
+
2008-10-09 Michael Snyder <msnyder@vmware.com>
* reverse.c (exec_reverse_once): Eliminate fixed-size buffer,
--- a/record.c
+++ b/record.c
@@ -37,8 +37,8 @@ record_t *record_arch_list_head = NULL;
record_t *record_arch_list_tail = NULL;
struct regcache *record_regcache = NULL;
-/* 0 ask user. 1 auto delete the last record_t. */
-static int record_insn_max_mode = 0;
+/* 1 ask user. 0 auto delete the last record_t. */
+static int record_stop_at_limit = 1;
static int record_insn_max_num = DEFAULT_RECORD_INSN_MAX_NUM;
static int record_insn_num = 0;
@@ -289,17 +289,17 @@ record_check_insn_num (int set_terminal)
if (record_insn_num == record_insn_max_num)
{
/* Ask user how to do */
- if (!record_insn_max_mode)
+ if (record_stop_at_limit)
{
int q;
if (set_terminal)
target_terminal_ours ();
- q = yquery (_("The record instruction number (record-insn-number) is equal to record-insn-number-max. Do you want to open auto delete first record_t function (record-auto-delete)?"));
+ q = yquery (_("The record instruction number (record-insn-number) is equal to record-insn-number-max. Do you want to close record/replay stop when record/replay buffer becomes full(record-stop-at-limit) then auto delete first record_t?"));
if (set_terminal)
target_terminal_inferior ();
if (q)
{
- record_insn_max_mode = 1;
+ record_stop_at_limit = 0;
}
else
{
@@ -1108,11 +1108,14 @@ _initialize_record (void)
add_com_alias ("sr", "stoprecord", class_obscure, 1);
/* Record instructions number limit command. */
- add_setshow_zinteger_cmd ("record-auto-delete", no_class,
- &record_insn_max_mode,
- _("Set record/replay auto delete mode."),
- _("Show record/replay auto delete mode."), _("\
-When enabled, if the record/replay buffer becomes full,\n\
+ add_setshow_boolean_cmd ("record-stop-at-limit", no_class,
+ &record_stop_at_limit,
+ _("Set record/replay stop when record/replay buffer becomes full."),
+ _("Show record/replay stop when record/replay buffer becomes full."), _("\
+Enable is default value.\n\
+When enable, if the record/replay buffer becomes full,\n\
+ask user how to do.\n\
+When disable, if the record/replay buffer becomes full,\n\
delete it and start new recording."), NULL, NULL, &setlist, &showlist);
add_setshow_zinteger_cmd ("record-insn-number-max", no_class,
&record_insn_max_num,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [reverse RFA] Change "record-auto-delete" to "record-stop-at-limit"
2008-10-15 8:09 [reverse RFA] Change "record-auto-delete" to "record-stop-at-limit" teawater
@ 2008-10-15 18:46 ` Michael Snyder
2008-10-16 1:54 ` teawater
0 siblings, 1 reply; 3+ messages in thread
From: Michael Snyder @ 2008-10-15 18:46 UTC (permalink / raw)
To: teawater; +Cc: gdb-patches
Looks ok to me. ;-)
teawater wrote:
> Hi Michael,
>
> According to Eli's suggest, Change "record-auto-delete" to
> "record-stop-at-limit".
>
> 2008-10-15 Hui Zhu <teawater@gmail.com>
>
> Change "record-auto-delete" to "record-stop-at-limit".
>
> * record.c (record_insn_max_mode): Change to
> "record_stop_at_limit".
> (record_check_insn_num): Ditto.
> (_initialize_record): Ditto.
>
> Thanks,
> Hui
>
>
> ------------------------------------------------------------------------
>
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,12 @@
> +2008-10-15 Hui Zhu <teawater@gmail.com>
> +
> + Change "record-auto-delete" to "record-stop-at-limit".
> +
> + * record.c (record_insn_max_mode): Change to
> + "record_stop_at_limit".
> + (record_check_insn_num): Ditto.
> + (_initialize_record): Ditto.
> +
> 2008-10-09 Michael Snyder <msnyder@vmware.com>
>
> * reverse.c (exec_reverse_once): Eliminate fixed-size buffer,
> --- a/record.c
> +++ b/record.c
> @@ -37,8 +37,8 @@ record_t *record_arch_list_head = NULL;
> record_t *record_arch_list_tail = NULL;
> struct regcache *record_regcache = NULL;
>
> -/* 0 ask user. 1 auto delete the last record_t. */
> -static int record_insn_max_mode = 0;
> +/* 1 ask user. 0 auto delete the last record_t. */
> +static int record_stop_at_limit = 1;
> static int record_insn_max_num = DEFAULT_RECORD_INSN_MAX_NUM;
> static int record_insn_num = 0;
>
> @@ -289,17 +289,17 @@ record_check_insn_num (int set_terminal)
> if (record_insn_num == record_insn_max_num)
> {
> /* Ask user how to do */
> - if (!record_insn_max_mode)
> + if (record_stop_at_limit)
> {
> int q;
> if (set_terminal)
> target_terminal_ours ();
> - q = yquery (_("The record instruction number (record-insn-number) is equal to record-insn-number-max. Do you want to open auto delete first record_t function (record-auto-delete)?"));
> + q = yquery (_("The record instruction number (record-insn-number) is equal to record-insn-number-max. Do you want to close record/replay stop when record/replay buffer becomes full(record-stop-at-limit) then auto delete first record_t?"));
> if (set_terminal)
> target_terminal_inferior ();
> if (q)
> {
> - record_insn_max_mode = 1;
> + record_stop_at_limit = 0;
> }
> else
> {
> @@ -1108,11 +1108,14 @@ _initialize_record (void)
> add_com_alias ("sr", "stoprecord", class_obscure, 1);
>
> /* Record instructions number limit command. */
> - add_setshow_zinteger_cmd ("record-auto-delete", no_class,
> - &record_insn_max_mode,
> - _("Set record/replay auto delete mode."),
> - _("Show record/replay auto delete mode."), _("\
> -When enabled, if the record/replay buffer becomes full,\n\
> + add_setshow_boolean_cmd ("record-stop-at-limit", no_class,
> + &record_stop_at_limit,
> + _("Set record/replay stop when record/replay buffer becomes full."),
> + _("Show record/replay stop when record/replay buffer becomes full."), _("\
> +Enable is default value.\n\
> +When enable, if the record/replay buffer becomes full,\n\
> +ask user how to do.\n\
> +When disable, if the record/replay buffer becomes full,\n\
> delete it and start new recording."), NULL, NULL, &setlist, &showlist);
> add_setshow_zinteger_cmd ("record-insn-number-max", no_class,
> &record_insn_max_num,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [reverse RFA] Change "record-auto-delete" to "record-stop-at-limit"
2008-10-15 18:46 ` Michael Snyder
@ 2008-10-16 1:54 ` teawater
0 siblings, 0 replies; 3+ messages in thread
From: teawater @ 2008-10-16 1:54 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches
Thanks! I've checked it in.
On Thu, Oct 16, 2008 at 02:42, Michael Snyder <msnyder@vmware.com> wrote:
> Looks ok to me. ;-)
>
> teawater wrote:
>>
>> Hi Michael,
>>
>> According to Eli's suggest, Change "record-auto-delete" to
>> "record-stop-at-limit".
>>
>> 2008-10-15 Hui Zhu <teawater@gmail.com>
>>
>> Change "record-auto-delete" to "record-stop-at-limit".
>>
>> * record.c (record_insn_max_mode): Change to
>> "record_stop_at_limit".
>> (record_check_insn_num): Ditto.
>> (_initialize_record): Ditto.
>>
>> Thanks,
>> Hui
>>
>>
>> ------------------------------------------------------------------------
>>
>> --- a/ChangeLog
>> +++ b/ChangeLog
>> @@ -1,3 +1,12 @@
>> +2008-10-15 Hui Zhu <teawater@gmail.com>
>> +
>> + Change "record-auto-delete" to "record-stop-at-limit".
>> +
>> + * record.c (record_insn_max_mode): Change to
>> + "record_stop_at_limit".
>> + (record_check_insn_num): Ditto.
>> + (_initialize_record): Ditto.
>> +
>> 2008-10-09 Michael Snyder <msnyder@vmware.com>
>> * reverse.c (exec_reverse_once): Eliminate fixed-size buffer,
>> --- a/record.c
>> +++ b/record.c
>> @@ -37,8 +37,8 @@ record_t *record_arch_list_head = NULL;
>> record_t *record_arch_list_tail = NULL;
>> struct regcache *record_regcache = NULL;
>> -/* 0 ask user. 1 auto delete the last record_t. */
>> -static int record_insn_max_mode = 0;
>> +/* 1 ask user. 0 auto delete the last record_t. */
>> +static int record_stop_at_limit = 1;
>> static int record_insn_max_num = DEFAULT_RECORD_INSN_MAX_NUM;
>> static int record_insn_num = 0;
>> @@ -289,17 +289,17 @@ record_check_insn_num (int set_terminal)
>> if (record_insn_num == record_insn_max_num)
>> {
>> /* Ask user how to do */
>> - if (!record_insn_max_mode)
>> + if (record_stop_at_limit)
>> {
>> int q;
>> if (set_terminal)
>> target_terminal_ours ();
>> - q = yquery (_("The record instruction number
>> (record-insn-number) is equal to record-insn-number-max. Do you want to
>> open auto delete first record_t function (record-auto-delete)?"));
>> + q = yquery (_("The record instruction number
>> (record-insn-number) is equal to record-insn-number-max. Do you want to
>> close record/replay stop when record/replay buffer becomes
>> full(record-stop-at-limit) then auto delete first record_t?"));
>> if (set_terminal)
>> target_terminal_inferior ();
>> if (q)
>> {
>> - record_insn_max_mode = 1;
>> + record_stop_at_limit = 0;
>> }
>> else
>> {
>> @@ -1108,11 +1108,14 @@ _initialize_record (void)
>> add_com_alias ("sr", "stoprecord", class_obscure, 1);
>> /* Record instructions number limit command. */
>> - add_setshow_zinteger_cmd ("record-auto-delete", no_class,
>> - &record_insn_max_mode,
>> - _("Set record/replay auto delete mode."),
>> - _("Show record/replay auto delete mode."),
>> _("\
>> -When enabled, if the record/replay buffer becomes full,\n\
>> + add_setshow_boolean_cmd ("record-stop-at-limit", no_class,
>> + &record_stop_at_limit,
>> + _("Set record/replay stop when record/replay
>> buffer becomes full."),
>> + _("Show record/replay stop when record/replay
>> buffer becomes full."), _("\
>> +Enable is default value.\n\
>> +When enable, if the record/replay buffer becomes full,\n\
>> +ask user how to do.\n\
>> +When disable, if the record/replay buffer becomes full,\n\
>> delete it and start new recording."), NULL, NULL, &setlist, &showlist);
>> add_setshow_zinteger_cmd ("record-insn-number-max", no_class,
>> &record_insn_max_num,
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-16 1:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-15 8:09 [reverse RFA] Change "record-auto-delete" to "record-stop-at-limit" teawater
2008-10-15 18:46 ` Michael Snyder
2008-10-16 1:54 ` teawater
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox