From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14442 invoked by alias); 15 Oct 2008 18:46:46 -0000 Received: (qmail 14433 invoked by uid 22791); 15 Oct 2008 18:46:45 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 15 Oct 2008 18:46:10 +0000 Received: from mailhost5.vmware.com (mailhost5.vmware.com [10.16.68.131]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 0773635003; Wed, 15 Oct 2008 11:46:08 -0700 (PDT) Received: from [10.20.92.59] (promb-2s-dhcp59.eng.vmware.com [10.20.92.59]) by mailhost5.vmware.com (Postfix) with ESMTP id E7267DC061; Wed, 15 Oct 2008 11:46:07 -0700 (PDT) Message-ID: <48F639A2.8030002@vmware.com> Date: Wed, 15 Oct 2008 18:46:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: teawater CC: gdb-patches Subject: Re: [reverse RFA] Change "record-auto-delete" to "record-stop-at-limit" References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00378.txt.bz2 Looks ok to me. ;-) teawater wrote: > Hi Michael, > > According to Eli's suggest, Change "record-auto-delete" to > "record-stop-at-limit". > > 2008-10-15 Hui Zhu > > Change "record-auto-delete" to "record-stop-at-limit". > > * record.c (record_insn_max_mode): Change to > "record_stop_at_limit". > (record_check_insn_num): Ditto. > (_initialize_record): Ditto. > > Thanks, > Hui > > > ------------------------------------------------------------------------ > > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,12 @@ > +2008-10-15 Hui Zhu > + > + Change "record-auto-delete" to "record-stop-at-limit". > + > + * record.c (record_insn_max_mode): Change to > + "record_stop_at_limit". > + (record_check_insn_num): Ditto. > + (_initialize_record): Ditto. > + > 2008-10-09 Michael Snyder > > * reverse.c (exec_reverse_once): Eliminate fixed-size buffer, > --- a/record.c > +++ b/record.c > @@ -37,8 +37,8 @@ record_t *record_arch_list_head = NULL; > record_t *record_arch_list_tail = NULL; > struct regcache *record_regcache = NULL; > > -/* 0 ask user. 1 auto delete the last record_t. */ > -static int record_insn_max_mode = 0; > +/* 1 ask user. 0 auto delete the last record_t. */ > +static int record_stop_at_limit = 1; > static int record_insn_max_num = DEFAULT_RECORD_INSN_MAX_NUM; > static int record_insn_num = 0; > > @@ -289,17 +289,17 @@ record_check_insn_num (int set_terminal) > if (record_insn_num == record_insn_max_num) > { > /* Ask user how to do */ > - if (!record_insn_max_mode) > + if (record_stop_at_limit) > { > int q; > if (set_terminal) > target_terminal_ours (); > - q = yquery (_("The record instruction number (record-insn-number) is equal to record-insn-number-max. Do you want to open auto delete first record_t function (record-auto-delete)?")); > + q = yquery (_("The record instruction number (record-insn-number) is equal to record-insn-number-max. Do you want to close record/replay stop when record/replay buffer becomes full(record-stop-at-limit) then auto delete first record_t?")); > if (set_terminal) > target_terminal_inferior (); > if (q) > { > - record_insn_max_mode = 1; > + record_stop_at_limit = 0; > } > else > { > @@ -1108,11 +1108,14 @@ _initialize_record (void) > add_com_alias ("sr", "stoprecord", class_obscure, 1); > > /* Record instructions number limit command. */ > - add_setshow_zinteger_cmd ("record-auto-delete", no_class, > - &record_insn_max_mode, > - _("Set record/replay auto delete mode."), > - _("Show record/replay auto delete mode."), _("\ > -When enabled, if the record/replay buffer becomes full,\n\ > + add_setshow_boolean_cmd ("record-stop-at-limit", no_class, > + &record_stop_at_limit, > + _("Set record/replay stop when record/replay buffer becomes full."), > + _("Show record/replay stop when record/replay buffer becomes full."), _("\ > +Enable is default value.\n\ > +When enable, if the record/replay buffer becomes full,\n\ > +ask user how to do.\n\ > +When disable, if the record/replay buffer becomes full,\n\ > delete it and start new recording."), NULL, NULL, &setlist, &showlist); > add_setshow_zinteger_cmd ("record-insn-number-max", no_class, > &record_insn_max_num,