From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30874 invoked by alias); 16 Oct 2008 01:54:27 -0000 Received: (qmail 30528 invoked by uid 22791); 16 Oct 2008 01:54:26 -0000 X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.186) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 16 Oct 2008 01:53:51 +0000 Received: by ti-out-0910.google.com with SMTP id d10so1936848tib.12 for ; Wed, 15 Oct 2008 18:53:48 -0700 (PDT) Received: by 10.110.69.5 with SMTP id r5mr1392086tia.17.1224122028222; Wed, 15 Oct 2008 18:53:48 -0700 (PDT) Received: by 10.110.42.9 with HTTP; Wed, 15 Oct 2008 18:53:48 -0700 (PDT) Message-ID: Date: Thu, 16 Oct 2008 01:54:00 -0000 From: teawater To: "Michael Snyder" Subject: Re: [reverse RFA] Change "record-auto-delete" to "record-stop-at-limit" Cc: gdb-patches In-Reply-To: <48F639A2.8030002@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <48F639A2.8030002@vmware.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00387.txt.bz2 Thanks! I've checked it in. On Thu, Oct 16, 2008 at 02:42, Michael Snyder wrote: > Looks ok to me. ;-) > > teawater wrote: >> >> Hi Michael, >> >> According to Eli's suggest, Change "record-auto-delete" to >> "record-stop-at-limit". >> >> 2008-10-15 Hui Zhu >> >> Change "record-auto-delete" to "record-stop-at-limit". >> >> * record.c (record_insn_max_mode): Change to >> "record_stop_at_limit". >> (record_check_insn_num): Ditto. >> (_initialize_record): Ditto. >> >> Thanks, >> Hui >> >> >> ------------------------------------------------------------------------ >> >> --- a/ChangeLog >> +++ b/ChangeLog >> @@ -1,3 +1,12 @@ >> +2008-10-15 Hui Zhu >> + >> + Change "record-auto-delete" to "record-stop-at-limit". >> + >> + * record.c (record_insn_max_mode): Change to >> + "record_stop_at_limit". >> + (record_check_insn_num): Ditto. >> + (_initialize_record): Ditto. >> + >> 2008-10-09 Michael Snyder >> * reverse.c (exec_reverse_once): Eliminate fixed-size buffer, >> --- a/record.c >> +++ b/record.c >> @@ -37,8 +37,8 @@ record_t *record_arch_list_head = NULL; >> record_t *record_arch_list_tail = NULL; >> struct regcache *record_regcache = NULL; >> -/* 0 ask user. 1 auto delete the last record_t. */ >> -static int record_insn_max_mode = 0; >> +/* 1 ask user. 0 auto delete the last record_t. */ >> +static int record_stop_at_limit = 1; >> static int record_insn_max_num = DEFAULT_RECORD_INSN_MAX_NUM; >> static int record_insn_num = 0; >> @@ -289,17 +289,17 @@ record_check_insn_num (int set_terminal) >> if (record_insn_num == record_insn_max_num) >> { >> /* Ask user how to do */ >> - if (!record_insn_max_mode) >> + if (record_stop_at_limit) >> { >> int q; >> if (set_terminal) >> target_terminal_ours (); >> - q = yquery (_("The record instruction number >> (record-insn-number) is equal to record-insn-number-max. Do you want to >> open auto delete first record_t function (record-auto-delete)?")); >> + q = yquery (_("The record instruction number >> (record-insn-number) is equal to record-insn-number-max. Do you want to >> close record/replay stop when record/replay buffer becomes >> full(record-stop-at-limit) then auto delete first record_t?")); >> if (set_terminal) >> target_terminal_inferior (); >> if (q) >> { >> - record_insn_max_mode = 1; >> + record_stop_at_limit = 0; >> } >> else >> { >> @@ -1108,11 +1108,14 @@ _initialize_record (void) >> add_com_alias ("sr", "stoprecord", class_obscure, 1); >> /* Record instructions number limit command. */ >> - add_setshow_zinteger_cmd ("record-auto-delete", no_class, >> - &record_insn_max_mode, >> - _("Set record/replay auto delete mode."), >> - _("Show record/replay auto delete mode."), >> _("\ >> -When enabled, if the record/replay buffer becomes full,\n\ >> + add_setshow_boolean_cmd ("record-stop-at-limit", no_class, >> + &record_stop_at_limit, >> + _("Set record/replay stop when record/replay >> buffer becomes full."), >> + _("Show record/replay stop when record/replay >> buffer becomes full."), _("\ >> +Enable is default value.\n\ >> +When enable, if the record/replay buffer becomes full,\n\ >> +ask user how to do.\n\ >> +When disable, if the record/replay buffer becomes full,\n\ >> delete it and start new recording."), NULL, NULL, &setlist, &showlist); >> add_setshow_zinteger_cmd ("record-insn-number-max", no_class, >> &record_insn_max_num, > >