Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: David Daney <ddaney@avtrex.com>
To: gdb-patches@sourceware.org
Subject: [Patch] Fix 'incomplete type' warning in dummy_frame.h
Date: Mon, 08 Sep 2008 01:00:00 -0000	[thread overview]
Message-ID: <48C478FF.9080909@avtrex.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

Back on 2008-08-26, Ulrich Weigand added a declaration for
dummy_frame_pop to dummy_frame.h.  This causes a fatal warning when I
build with gcc-3.4 targeting mipsel-linux-gnu because struct frame_id is
an incomplete type.

Adding #include "frame.h" fixes the problem for me.

I'm don'e think I have write access to gdb (I do have it in binutils),
so if it is OK, someone will either have to commit it or turn on write
access for me.

2008-09-07  David Daney  <ddaney@avtrex.com>

	* dummy-frame.h (frame.h): Include it.
	(struct frame_id): Remove declaration.


[-- Attachment #2: dummy_frame.h.patch --]
[-- Type: text/plain, Size: 572 bytes --]

Index: dummy-frame.h
===================================================================
RCS file: /cvs/src/src/gdb/dummy-frame.h,v
retrieving revision 1.22
diff -u -p -r1.22 dummy-frame.h
--- dummy-frame.h	26 Aug 2008 17:40:24 -0000	1.22
+++ dummy-frame.h	8 Sep 2008 00:43:01 -0000
@@ -20,10 +20,10 @@
 #if !defined (DUMMY_FRAME_H)
 #define DUMMY_FRAME_H 1
 
+#include "frame.h"
 struct frame_info;
 struct regcache;
 struct frame_unwind;
-struct frame_id;
 
 /* Push the information needed to identify, and unwind from, a dummy
    frame onto the dummy frame stack.  */

             reply	other threads:[~2008-09-08  1:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-08  1:00 David Daney [this message]
2008-09-08 11:25 ` Ulrich Weigand
2008-09-08 15:36   ` David Daney
2008-09-08 16:16     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48C478FF.9080909@avtrex.com \
    --to=ddaney@avtrex.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox