From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 615 invoked by alias); 8 Sep 2008 01:00:25 -0000 Received: (qmail 604 invoked by uid 22791); 8 Sep 2008 01:00:24 -0000 X-Spam-Check-By: sourceware.org Received: from smtp1.dnsmadeeasy.com (HELO smtp1.dnsmadeeasy.com) (205.234.170.134) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 08 Sep 2008 00:59:44 +0000 Received: from smtp1.dnsmadeeasy.com (localhost [127.0.0.1]) by smtp1.dnsmadeeasy.com (Postfix) with ESMTP id 5BFE832095D for ; Mon, 8 Sep 2008 01:00:00 +0000 (UTC) X-Authenticated-Name: js.dnsmadeeasy X-Transit-System: In case of SPAM please contact abuse@dnsmadeeasy.com Received: from avtrex.com (unknown [173.8.135.205]) by smtp1.dnsmadeeasy.com (Postfix) with ESMTP for ; Mon, 8 Sep 2008 01:00:00 +0000 (UTC) Received: from silver64.hq2.avtrex.com ([192.168.7.229]) by avtrex.com with Microsoft SMTPSVC(6.0.3790.1830); Sun, 7 Sep 2008 17:59:40 -0700 Message-ID: <48C478FF.9080909@avtrex.com> Date: Mon, 08 Sep 2008 01:00:00 -0000 From: David Daney User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: [Patch] Fix 'incomplete type' warning in dummy_frame.h Content-Type: multipart/mixed; boundary="------------010104000403090705050507" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00153.txt.bz2 This is a multi-part message in MIME format. --------------010104000403090705050507 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 561 Back on 2008-08-26, Ulrich Weigand added a declaration for dummy_frame_pop to dummy_frame.h. This causes a fatal warning when I build with gcc-3.4 targeting mipsel-linux-gnu because struct frame_id is an incomplete type. Adding #include "frame.h" fixes the problem for me. I'm don'e think I have write access to gdb (I do have it in binutils), so if it is OK, someone will either have to commit it or turn on write access for me. 2008-09-07 David Daney * dummy-frame.h (frame.h): Include it. (struct frame_id): Remove declaration. --------------010104000403090705050507 Content-Type: text/plain; name="dummy_frame.h.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="dummy_frame.h.patch" Content-length: 572 Index: dummy-frame.h =================================================================== RCS file: /cvs/src/src/gdb/dummy-frame.h,v retrieving revision 1.22 diff -u -p -r1.22 dummy-frame.h --- dummy-frame.h 26 Aug 2008 17:40:24 -0000 1.22 +++ dummy-frame.h 8 Sep 2008 00:43:01 -0000 @@ -20,10 +20,10 @@ #if !defined (DUMMY_FRAME_H) #define DUMMY_FRAME_H 1 +#include "frame.h" struct frame_info; struct regcache; struct frame_unwind; -struct frame_id; /* Push the information needed to identify, and unwind from, a dummy frame onto the dummy frame stack. */ --------------010104000403090705050507--