From: Andreas Schwab <schwab@suse.de>
To: David Daney <ddaney@avtrex.com>
Cc: Ulrich Weigand <uweigand@de.ibm.com>, gdb-patches@sourceware.org
Subject: Re: [Patch] Fix 'incomplete type' warning in dummy_frame.h
Date: Mon, 08 Sep 2008 16:16:00 -0000 [thread overview]
Message-ID: <jeljy2pq9g.fsf@sykes.suse.de> (raw)
In-Reply-To: <48C5466D.6090906@avtrex.com> (David Daney's message of "Mon, 08 Sep 2008 08:36:13 -0700")
David Daney <ddaney@avtrex.com> writes:
> Ulrich Weigand wrote:
>> David Daney wrote:
>>
>>> Back on 2008-08-26, Ulrich Weigand added a declaration for
>>> dummy_frame_pop to dummy_frame.h. This causes a fatal warning when I
>>> build with gcc-3.4 targeting mipsel-linux-gnu because struct frame_id is
>>> an incomplete type.
>>>
>>> Adding #include "frame.h" fixes the problem for me.
>>
>> Huh. Sorry for the breakage. Strange that this compiles without even
>> a warning with GCC 4.1.1 ...
>
> I think it may depend on the ABI. The calling convention for passing a
> struct can vary depending on the size of the struct.
Only gcc 3.4 and before warn about this. The standard does not require
complete parameter types in a function prototype that isn't also a
definition.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
prev parent reply other threads:[~2008-09-08 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 1:00 David Daney
2008-09-08 11:25 ` Ulrich Weigand
2008-09-08 15:36 ` David Daney
2008-09-08 16:16 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jeljy2pq9g.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=ddaney@avtrex.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox