From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: ddaney@avtrex.com (David Daney)
Cc: gdb-patches@sourceware.org
Subject: Re: [Patch] Fix 'incomplete type' warning in dummy_frame.h
Date: Mon, 08 Sep 2008 11:25:00 -0000 [thread overview]
Message-ID: <200809081123.m88BNHHT030564@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <48C478FF.9080909@avtrex.com> from "David Daney" at Sep 07, 2008 05:59:43 PM
David Daney wrote:
> Back on 2008-08-26, Ulrich Weigand added a declaration for
> dummy_frame_pop to dummy_frame.h. This causes a fatal warning when I
> build with gcc-3.4 targeting mipsel-linux-gnu because struct frame_id is
> an incomplete type.
>
> Adding #include "frame.h" fixes the problem for me.
Huh. Sorry for the breakage. Strange that this compiles without even
a warning with GCC 4.1.1 ...
> I'm don'e think I have write access to gdb (I do have it in binutils),
> so if it is OK, someone will either have to commit it or turn on write
> access for me.
If you have access to binutils, you should also have access in GDB,
as both actually reside in the same src repository.
> 2008-09-07 David Daney <ddaney@avtrex.com>
>
> * dummy-frame.h (frame.h): Include it.
> (struct frame_id): Remove declaration.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2008-09-08 11:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 1:00 David Daney
2008-09-08 11:25 ` Ulrich Weigand [this message]
2008-09-08 15:36 ` David Daney
2008-09-08 16:16 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809081123.m88BNHHT030564@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=ddaney@avtrex.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox