From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15562 invoked by alias); 8 Sep 2008 11:25:09 -0000 Received: (qmail 15549 invoked by uid 22791); 8 Sep 2008 11:25:09 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 08 Sep 2008 11:24:23 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id m88BNKLS431468 for ; Mon, 8 Sep 2008 11:23:20 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m88BNKcA3989602 for ; Mon, 8 Sep 2008 13:23:20 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m88BNHJM030991 for ; Mon, 8 Sep 2008 13:23:17 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m88BNHHT030564; Mon, 8 Sep 2008 13:23:17 +0200 Message-Id: <200809081123.m88BNHHT030564@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 8 Sep 2008 13:22:54 +0200 Subject: Re: [Patch] Fix 'incomplete type' warning in dummy_frame.h To: ddaney@avtrex.com (David Daney) Date: Mon, 08 Sep 2008 11:25:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <48C478FF.9080909@avtrex.com> from "David Daney" at Sep 07, 2008 05:59:43 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00159.txt.bz2 David Daney wrote: > Back on 2008-08-26, Ulrich Weigand added a declaration for > dummy_frame_pop to dummy_frame.h. This causes a fatal warning when I > build with gcc-3.4 targeting mipsel-linux-gnu because struct frame_id is > an incomplete type. > > Adding #include "frame.h" fixes the problem for me. Huh. Sorry for the breakage. Strange that this compiles without even a warning with GCC 4.1.1 ... > I'm don'e think I have write access to gdb (I do have it in binutils), > so if it is OK, someone will either have to commit it or turn on write > access for me. If you have access to binutils, you should also have access in GDB, as both actually reside in the same src repository. > 2008-09-07 David Daney > > * dummy-frame.h (frame.h): Include it. > (struct frame_id): Remove declaration. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com