Re: [RFA] gdb_continue_to_breakpoint

[Michael Snyder <msnyder@vmware.com>]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Daniel Jacobowitz wrote:
> On Thu, Sep 04, 2008 at 02:26:17PM -0700, Michael Snyder wrote:
>> Yabbut, this isn't a test of symbol handling, it's
>> a test of continuing to a breakpoint.
> 
> True, though we have a lot of things that are tested 'all over' like
> this.
> 
>>> For the second part can you just put the .* at
>>> appropriate callers?
>> Sure, if you prefer.  So maybe remove the .* but accept
>> the (in|at)?
> 
> Yes please.  That part seems fine - it's not like nothing else will
> break if we end up unexpectedly without debug info :-).
> 

OK, revised and committed as attached.
Thanks


[-- Attachment #2: lib.txt --]
[-- Type: text/plain, Size: 738 bytes --]

2008-09-04  Michael Snyder  <msnyder@vmware.com>

	* lib/gdb.exp (gdb_continue_to_breakpoint): Accept "in" as well
	as "at" (for non-debug functions such as _start).

Index: lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.105
diff -u -p -r1.105 gdb.exp
--- lib/gdb.exp	15 Aug 2008 15:18:34 -0000	1.105
+++ lib/gdb.exp	4 Sep 2008 21:58:38 -0000
@@ -456,7 +456,7 @@ proc gdb_continue_to_breakpoint {name {l
 
     send_gdb "continue\n"
     gdb_expect {
-	-re "Breakpoint .* at $location_pattern\r\n$gdb_prompt $" {
+	-re "Breakpoint .* (at|in) $location_pattern\r\n$gdb_prompt $" {
 	    pass $full_name
 	}
 	-re ".*$gdb_prompt $" {