Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: Michael Snyder <msnyder@vmware.com>,
	  "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] gdb_continue_to_breakpoint
Date: Thu, 04 Sep 2008 21:27:00 -0000	[thread overview]
Message-ID: <48C05279.204@vmware.com> (raw)
In-Reply-To: <20080904210357.GA27480@caradoc.them.org>

Daniel Jacobowitz wrote:
> On Thu, Sep 04, 2008 at 01:52:40PM -0700, Michael Snyder wrote:
>> This one-line change affects two changes that make
>> gdb_continue_to_breakpoint more useful.
>>
>> 1) If we accept "Breakpoint in" as well as "Breakpoint at",
>> then it will work for non-debug functions.
>>
>> 2) If we accept trailing text after the $location_pattern,
>> then we are not forced to include a location pattern that
>> takes us up to the end of the line.
>>
> 
>> 2008-09-04  Michael Snyder  <msnyder@vmware.com>
>>
>>       * lib/gdb.exp (gdb_continue_to_breakpoint): Accept "in" as well
>>       as "at" (for non-debug functions such as _start).  Also accept
>>       trailing text after $location_pattern.
> 
> I dunno - when we get symbol handling confused, e.g. we can find a
> minsym but not the full symbol, we tend to get the wrong output from
> breakpoint messages. 

Yabbut, this isn't a test of symbol handling, it's
a test of continuing to a breakpoint.

> For the second part can you just put the .* at
> appropriate callers?

Sure, if you prefer.  So maybe remove the .* but accept
the (in|at)?


  reply	other threads:[~2008-09-04 21:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-04 20:53 Michael Snyder
2008-09-04 21:04 ` Daniel Jacobowitz
2008-09-04 21:27   ` Michael Snyder [this message]
2008-09-04 21:37     ` Daniel Jacobowitz
2008-09-04 22:03       ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48C05279.204@vmware.com \
    --to=msnyder@vmware.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox