From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22423 invoked by alias); 4 Sep 2008 21:27:16 -0000 Received: (qmail 22414 invoked by uid 22791); 4 Sep 2008 21:27:16 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 04 Sep 2008 21:26:41 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.64.160]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 3E4802C00A for ; Thu, 4 Sep 2008 14:26:40 -0700 (PDT) Received: from [10.20.92.218] (promb-2s-dhcp218.eng.vmware.com [10.20.92.218]) by mailhost2.vmware.com (Postfix) with ESMTP id 331FD8E590; Thu, 4 Sep 2008 14:26:40 -0700 (PDT) Message-ID: <48C05279.204@vmware.com> Date: Thu, 04 Sep 2008 21:27:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Michael Snyder , "gdb-patches@sourceware.org" Subject: Re: [RFA] gdb_continue_to_breakpoint References: <48C04A98.3020508@vmware.com> <20080904210357.GA27480@caradoc.them.org> In-Reply-To: <20080904210357.GA27480@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00075.txt.bz2 Daniel Jacobowitz wrote: > On Thu, Sep 04, 2008 at 01:52:40PM -0700, Michael Snyder wrote: >> This one-line change affects two changes that make >> gdb_continue_to_breakpoint more useful. >> >> 1) If we accept "Breakpoint in" as well as "Breakpoint at", >> then it will work for non-debug functions. >> >> 2) If we accept trailing text after the $location_pattern, >> then we are not forced to include a location pattern that >> takes us up to the end of the line. >> > >> 2008-09-04 Michael Snyder >> >> * lib/gdb.exp (gdb_continue_to_breakpoint): Accept "in" as well >> as "at" (for non-debug functions such as _start). Also accept >> trailing text after $location_pattern. > > I dunno - when we get symbol handling confused, e.g. we can find a > minsym but not the full symbol, we tend to get the wrong output from > breakpoint messages. Yabbut, this isn't a test of symbol handling, it's a test of continuing to a breakpoint. > For the second part can you just put the .* at > appropriate callers? Sure, if you prefer. So maybe remove the .* but accept the (in|at)?