From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12159 invoked by alias); 4 Sep 2008 22:03:28 -0000 Received: (qmail 12147 invoked by uid 22791); 4 Sep 2008 22:03:28 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 04 Sep 2008 22:02:53 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.64.160]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id EAD881D00F for ; Thu, 4 Sep 2008 15:02:50 -0700 (PDT) Received: from [10.20.92.218] (promb-2s-dhcp218.eng.vmware.com [10.20.92.218]) by mailhost2.vmware.com (Postfix) with ESMTP id DC0E18E5A8; Thu, 4 Sep 2008 15:02:50 -0700 (PDT) Message-ID: <48C05AF3.1020309@vmware.com> Date: Thu, 04 Sep 2008 22:03:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Michael Snyder , "gdb-patches@sourceware.org" Subject: Re: [RFA] gdb_continue_to_breakpoint References: <48C04A98.3020508@vmware.com> <20080904210357.GA27480@caradoc.them.org> <48C05279.204@vmware.com> <20080904213640.GA29721@caradoc.them.org> In-Reply-To: <20080904213640.GA29721@caradoc.them.org> Content-Type: multipart/mixed; boundary="------------030202090501060009090802" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00078.txt.bz2 This is a multi-part message in MIME format. --------------030202090501060009090802 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 604 Daniel Jacobowitz wrote: > On Thu, Sep 04, 2008 at 02:26:17PM -0700, Michael Snyder wrote: >> Yabbut, this isn't a test of symbol handling, it's >> a test of continuing to a breakpoint. > > True, though we have a lot of things that are tested 'all over' like > this. > >>> For the second part can you just put the .* at >>> appropriate callers? >> Sure, if you prefer. So maybe remove the .* but accept >> the (in|at)? > > Yes please. That part seems fine - it's not like nothing else will > break if we end up unexpectedly without debug info :-). > OK, revised and committed as attached. Thanks --------------030202090501060009090802 Content-Type: text/plain; name="lib.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="lib.txt" Content-length: 738 2008-09-04 Michael Snyder * lib/gdb.exp (gdb_continue_to_breakpoint): Accept "in" as well as "at" (for non-debug functions such as _start). Index: lib/gdb.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v retrieving revision 1.105 diff -u -p -r1.105 gdb.exp --- lib/gdb.exp 15 Aug 2008 15:18:34 -0000 1.105 +++ lib/gdb.exp 4 Sep 2008 21:58:38 -0000 @@ -456,7 +456,7 @@ proc gdb_continue_to_breakpoint {name {l send_gdb "continue\n" gdb_expect { - -re "Breakpoint .* at $location_pattern\r\n$gdb_prompt $" { + -re "Breakpoint .* (at|in) $location_pattern\r\n$gdb_prompt $" { pass $full_name } -re ".*$gdb_prompt $" { --------------030202090501060009090802--