Re: [patch] gdb/doc - PR2424 fix

Re: [patch] gdb/doc - PR2424 fix

[Aleksandar Ristovski]

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]

Eli Zaretskii wrote:
>> @@ -19107,7 +19108,7 @@
>>  ^running
>>  (gdb)
>>  @@Hello world
>> -*stopped,reason="breakpoint-hit",bkptno="2",frame=@{func="foo",args=[],
>>
+*stopped,reason="breakpoint-hit",disp="keep",bkptno="2",frame=@{func="foo",
args=[],
>>  file="hello.c",fullname="/home/foo/bar/hello.c",line="13"@}
> 
> The new line is too long, and will overflow the page margin in the
> printed version of the manual.  Please break it at a earlier place.
> 
>> @@ -20565,7 +20566,7 @@
>>  ^running
>>  
>>  (gdb)
>> -*stopped,reason="breakpoint-hit",bkptno="1",frame=@{func="main",
>>
+*stopped,reason="breakpoint-hit",disp="keep",bkptno="1",frame=@{func="main"
,
>>  args=[],file="try.c",fullname="/home/foo/bar/try.c",line="5"@}
>>  (gdb)
> 
> Same here.
> 
> Other than that, the patch is approved.
> 

Committed, final patch attached.



[-- Attachment #2: PR2424gdb.texinfo.diff --]
[-- Type: text/plain, Size: 2703 bytes --]

Index: gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.480
diff -u -r1.480 gdb.texinfo
--- gdb.texinfo	9 Apr 2008 13:29:53 -0000	1.480
+++ gdb.texinfo	16 Apr 2008 13:12:36 -0000
@@ -18145,7 +18145,7 @@
 -> -exec-run
 <- ^running
 <- (gdb)
-<- *stopped,reason="breakpoint-hit",bkptno="1",thread-id="0",
+<- *stopped,reason="breakpoint-hit",disp="keep",bkptno="1",thread-id="0",
    frame=@{addr="0x08048564",func="main",
    args=[@{name="argc",value="1"@},@{name="argv",value="0xbfc4d4d4"@}],
    file="myprog.c",fullname="/home/nickrob/myprog.c",line="68"@}
@@ -18247,7 +18247,8 @@
 @smallexample
 (gdb)
 -break-insert main
-^done,bkpt=@{number="1",addr="0x000100d0",file="hello.c",
+^done,bkpt=@{number="1",type="breakpoint",disp="keep",
+enabled="y",addr="0x000100d0",func="main",file="hello.c",
 fullname="/home/foo/hello.c",line="5",times="0"@}
 (gdb)
 -break-after 1 3
@@ -19107,8 +19108,9 @@
 ^running
 (gdb)
 @@Hello world
-*stopped,reason="breakpoint-hit",bkptno="2",frame=@{func="foo",args=[],
-file="hello.c",fullname="/home/foo/bar/hello.c",line="13"@}
+*stopped,reason="breakpoint-hit",disp="keep",bkptno="2",frame=@{
+func="foo",args=[],file="hello.c",fullname="/home/foo/bar/hello.c",
+line="13"@}
 (gdb)
 @end smallexample
 
@@ -19287,7 +19289,7 @@
 000-exec-run
 000^running
 (gdb)
-000*stopped,reason="breakpoint-hit",bkptno="1",
+000*stopped,reason="breakpoint-hit",disp="keep",bkptno="1",
 frame=@{func="callee4",args=[],
 file="../../../devo/gdb/testsuite/gdb.mi/basics.c",
 fullname="/home/foo/bar/devo/gdb/testsuite/gdb.mi/basics.c",line="8"@}
@@ -19333,7 +19335,7 @@
 -exec-run
 ^running
 (gdb)
-*stopped,reason="breakpoint-hit",bkptno="1",
+*stopped,reason="breakpoint-hit",disp="keep",bkptno="1",
 frame=@{func="main",args=[],file="recursive2.c",
 fullname="/home/foo/bar/recursive2.c",line="4"@}
 (gdb)
@@ -20565,8 +20567,9 @@
 ^running
 
 (gdb)
-*stopped,reason="breakpoint-hit",bkptno="1",frame=@{func="main",
-args=[],file="try.c",fullname="/home/foo/bar/try.c",line="5"@}
+*stopped,reason="breakpoint-hit",disp="keep",bkptno="1",frame=@{
+func="main",args=[],file="try.c",fullname="/home/foo/bar/try.c",
+line="5"@}
 (gdb)
 -data-list-changed-registers
 ^done,changed-registers=["0","1","2","4","5","6","7","8","9",
@@ -22016,7 +22019,7 @@
 -exec-run
 ^running
 (gdb)
-*stopped,reason="breakpoint-hit",bkptno="1",thread-id="0",
+*stopped,reason="breakpoint-hit",disp="keep",bkptno="1",thread-id="0",
 frame=@{addr="0x080484ed",func="main",args=[@{name="argc",value="1"@},
 @{name="argv",value="0xbfb60364"@}],file="myprog.c",
 fullname="/home/nickrob/myprog.c",line="73"@}

[patch] gdb/doc - PR2424 fix

[Aleksandar Ristovski]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hello,

The documentation changes for the patch for PR2424.

(related thread: 
http://sourceware.org/ml/gdb-patches/2008-04/msg00243.html)

Thanks,
Aleksandar Ristovski
QNX Software Systems


2008-04-15  Aleksandar Ristovski  <aristovski@qnx.com>

	* gdb.texinfo (GDB/MI Simple Examples): Added 'disp' field to the
	sample output for 'stopped,reason="breakpoint-hit"' message.
	(GDB/MI Program Execution): Likewise.


[-- Attachment #2: gdb.texinfo.diff --]
[-- Type: text/plain, Size: 2533 bytes --]

Index: gdb/doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.480
diff -u -r1.480 gdb.texinfo
--- gdb/doc/gdb.texinfo	9 Apr 2008 13:29:53 -0000	1.480
+++ gdb/doc/gdb.texinfo	15 Apr 2008 17:08:16 -0000
@@ -18145,7 +18145,7 @@
 -> -exec-run
 <- ^running
 <- (gdb)
-<- *stopped,reason="breakpoint-hit",bkptno="1",thread-id="0",
+<- *stopped,reason="breakpoint-hit",disp="keep",bkptno="1",thread-id="0",
    frame=@{addr="0x08048564",func="main",
    args=[@{name="argc",value="1"@},@{name="argv",value="0xbfc4d4d4"@}],
    file="myprog.c",fullname="/home/nickrob/myprog.c",line="68"@}
@@ -18247,7 +18247,8 @@
 @smallexample
 (gdb)
 -break-insert main
-^done,bkpt=@{number="1",addr="0x000100d0",file="hello.c",
+^done,bkpt=@{number="1",type="breakpoint",disp="keep",
+enabled="y",addr="0x000100d0",func="main",file="hello.c",
 fullname="/home/foo/hello.c",line="5",times="0"@}
 (gdb)
 -break-after 1 3
@@ -19107,7 +19108,7 @@
 ^running
 (gdb)
 @@Hello world
-*stopped,reason="breakpoint-hit",bkptno="2",frame=@{func="foo",args=[],
+*stopped,reason="breakpoint-hit",disp="keep",bkptno="2",frame=@{func="foo",args=[],
 file="hello.c",fullname="/home/foo/bar/hello.c",line="13"@}
 (gdb)
 @end smallexample
@@ -19287,7 +19288,7 @@
 000-exec-run
 000^running
 (gdb)
-000*stopped,reason="breakpoint-hit",bkptno="1",
+000*stopped,reason="breakpoint-hit",disp="keep",bkptno="1",
 frame=@{func="callee4",args=[],
 file="../../../devo/gdb/testsuite/gdb.mi/basics.c",
 fullname="/home/foo/bar/devo/gdb/testsuite/gdb.mi/basics.c",line="8"@}
@@ -19333,7 +19334,7 @@
 -exec-run
 ^running
 (gdb)
-*stopped,reason="breakpoint-hit",bkptno="1",
+*stopped,reason="breakpoint-hit",disp="keep",bkptno="1",
 frame=@{func="main",args=[],file="recursive2.c",
 fullname="/home/foo/bar/recursive2.c",line="4"@}
 (gdb)
@@ -20565,7 +20566,7 @@
 ^running
 
 (gdb)
-*stopped,reason="breakpoint-hit",bkptno="1",frame=@{func="main",
+*stopped,reason="breakpoint-hit",disp="keep",bkptno="1",frame=@{func="main",
 args=[],file="try.c",fullname="/home/foo/bar/try.c",line="5"@}
 (gdb)
 -data-list-changed-registers
@@ -22016,7 +22017,7 @@
 -exec-run
 ^running
 (gdb)
-*stopped,reason="breakpoint-hit",bkptno="1",thread-id="0",
+*stopped,reason="breakpoint-hit",disp="keep",bkptno="1",thread-id="0",
 frame=@{addr="0x080484ed",func="main",args=[@{name="argc",value="1"@},
 @{name="argv",value="0xbfb60364"@}],file="myprog.c",
 fullname="/home/nickrob/myprog.c",line="73"@}

Re: [patch] gdb/doc - PR2424 fix

[Eli Zaretskii]

> From: Aleksandar Ristovski <ARistovski@qnx.com>
> Date: Tue, 15 Apr 2008 13:13:37 -0400
> 
> The documentation changes for the patch for PR2424.
> 
> (related thread: 
> http://sourceware.org/ml/gdb-patches/2008-04/msg00243.html)
> 
> Thanks,
> Aleksandar Ristovski
> QNX Software Systems

Thanks.

> @@ -19107,7 +19108,7 @@
>  ^running
>  (gdb)
>  @@Hello world
> -*stopped,reason="breakpoint-hit",bkptno="2",frame=@{func="foo",args=[],
> +*stopped,reason="breakpoint-hit",disp="keep",bkptno="2",frame=@{func="foo",args=[],
>  file="hello.c",fullname="/home/foo/bar/hello.c",line="13"@}

The new line is too long, and will overflow the page margin in the
printed version of the manual.  Please break it at a earlier place.

> @@ -20565,7 +20566,7 @@
>  ^running
>  
>  (gdb)
> -*stopped,reason="breakpoint-hit",bkptno="1",frame=@{func="main",
> +*stopped,reason="breakpoint-hit",disp="keep",bkptno="1",frame=@{func="main",
>  args=[],file="try.c",fullname="/home/foo/bar/try.c",line="5"@}
>  (gdb)

Same here.

Other than that, the patch is approved.