Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Aleksandar Ristovski <ARistovski@qnx.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] gdb/doc - PR2424 fix
Date: Tue, 15 Apr 2008 20:47:00 -0000	[thread overview]
Message-ID: <uiqyiri6c.fsf@gnu.org> (raw)
In-Reply-To: <4804E241.8060907@qnx.com>

> From: Aleksandar Ristovski <ARistovski@qnx.com>
> Date: Tue, 15 Apr 2008 13:13:37 -0400
> 
> The documentation changes for the patch for PR2424.
> 
> (related thread: 
> http://sourceware.org/ml/gdb-patches/2008-04/msg00243.html)
> 
> Thanks,
> Aleksandar Ristovski
> QNX Software Systems

Thanks.

> @@ -19107,7 +19108,7 @@
>  ^running
>  (gdb)
>  @@Hello world
> -*stopped,reason="breakpoint-hit",bkptno="2",frame=@{func="foo",args=[],
> +*stopped,reason="breakpoint-hit",disp="keep",bkptno="2",frame=@{func="foo",args=[],
>  file="hello.c",fullname="/home/foo/bar/hello.c",line="13"@}

The new line is too long, and will overflow the page margin in the
printed version of the manual.  Please break it at a earlier place.

> @@ -20565,7 +20566,7 @@
>  ^running
>  
>  (gdb)
> -*stopped,reason="breakpoint-hit",bkptno="1",frame=@{func="main",
> +*stopped,reason="breakpoint-hit",disp="keep",bkptno="1",frame=@{func="main",
>  args=[],file="try.c",fullname="/home/foo/bar/try.c",line="5"@}
>  (gdb)

Same here.

Other than that, the patch is approved.


  reply	other threads:[~2008-04-15 20:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-15 18:12 Aleksandar Ristovski
2008-04-15 20:47 ` Eli Zaretskii [this message]
2008-04-16 18:56 Aleksandar Ristovski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uiqyiri6c.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=ARistovski@qnx.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox