From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-55174-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20370 invoked by alias); 15 Apr 2008 20:13:57 -0000
Received: (qmail 20358 invoked by uid 22791); 15 Apr 2008 20:13:57 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout4.012.net.il (HELO mtaout4.012.net.il) (84.95.2.10)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 15 Apr 2008 20:13:28 +0000
Received: from HOME-C4E4A596F7 ([83.130.246.94]) by i_mtaout4.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0JZD005SEVGMOZN1@i_mtaout4.012.net.il> for gdb-patches@sourceware.org; Tue, 15 Apr 2008 23:26:46 +0300 (IDT)
Date: Tue, 15 Apr 2008 20:47:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] gdb/doc - PR2424 fix
In-reply-to: <4804E241.8060907@qnx.com>
X-012-Sender: halo1@inter.net.il
To: Aleksandar Ristovski <ARistovski@qnx.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uiqyiri6c.fsf@gnu.org>
References: <4804E241.8060907@qnx.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-04/txt/msg00298.txt.bz2

> From: Aleksandar Ristovski <ARistovski@qnx.com>
> Date: Tue, 15 Apr 2008 13:13:37 -0400
> 
> The documentation changes for the patch for PR2424.
> 
> (related thread: 
> http://sourceware.org/ml/gdb-patches/2008-04/msg00243.html)
> 
> Thanks,
> Aleksandar Ristovski
> QNX Software Systems

Thanks.

> @@ -19107,7 +19108,7 @@
>  ^running
>  (gdb)
>  @@Hello world
> -*stopped,reason="breakpoint-hit",bkptno="2",frame=@{func="foo",args=[],
> +*stopped,reason="breakpoint-hit",disp="keep",bkptno="2",frame=@{func="foo",args=[],
>  file="hello.c",fullname="/home/foo/bar/hello.c",line="13"@}

The new line is too long, and will overflow the page margin in the
printed version of the manual.  Please break it at a earlier place.

> @@ -20565,7 +20566,7 @@
>  ^running
>  
>  (gdb)
> -*stopped,reason="breakpoint-hit",bkptno="1",frame=@{func="main",
> +*stopped,reason="breakpoint-hit",disp="keep",bkptno="1",frame=@{func="main",
>  args=[],file="try.c",fullname="/home/foo/bar/try.c",line="5"@}
>  (gdb)

Same here.

Other than that, the patch is approved.