[patch] Expand psymtabs when needed - testcase

[patch] Expand psymtabs when needed - testcase

[Carlos Eduardo Seo]

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


This is a testcase for a patch I committed here:

http://sourceware.org/ml/gdb-patches/2007-10/msg00574.html

I used a C source that Jim Blandy posted in our discussions by that time
in this testcase:

http://sourceware.org/ml/gdb/2007-09/msg00252.html

Is this OK?

Thanks and regards,

- --
Carlos Eduardo Seo
Software Engineer
IBM Linux Technology Center
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHVclpqvq7Aov/qQARAtKrAJ9Jo1yc8eG9aejJLfZWCeSdrqXGGACghoSh
haFImQu+wbmBnzF8wp4IN6U=
=cAIl
-----END PGP SIGNATURE-----

[-- Attachment #2: expand-psymtabs-testcase.diff --]
[-- Type: text/x-patch, Size: 2786 bytes --]

2007-12-04  Carlos Eduardo Seo  <cseo@linux.vnet.ibm.com>
	    Jim Blandy  <jimb@codesourcery.com>

	* testsuite/gdb.base/expand-psymtabs.c: New testcase 
	source file.
	* testsuite/gdb.base/expand-psymtabs.exp: New testcase
	expect file.

Index: src/gdb/testsuite/gdb.base/expand-psymtabs.c
===================================================================
--- /dev/null
+++ src/gdb/testsuite/gdb.base/expand-psymtabs.c
@@ -0,0 +1,22 @@
+#include <stdio.h>
+
+extern void foo (void);
+
+#ifdef FIRST
+int
+main (int argc, char **argv)
+  {
+    puts ("main");
+    foo ();
+    puts ("main again");
+    return 0;
+  }
+
+#else
+void
+foo (void)
+  {
+    puts ("foo");
+  }
+
+#endif
Index: src/gdb/testsuite/gdb.base/expand-psymtabs.exp
===================================================================
--- /dev/null
+++ src/gdb/testsuite/gdb.base/expand-psymtabs.exp
@@ -0,0 +1,62 @@
+# Copyright 2007 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+#
+# This file is part of the gdb testsuite.
+
+if $tracelevel then {
+    strace $tracelevel
+}
+
+# Test expanding partial symtabs when needed.
+
+set testfile expand-psymtabs
+set srcfile ${testfile}.c
+set binfile ${objdir}/${subdir}/${testfile}
+set binfile_1 ${objdir}/${subdir}/${testfile}_1.o
+set binfile_2 ${objdir}/${subdir}/${testfile}_2.o
+
+
+# What compiler are we using?
+#
+if [get_compiler_info ${binfile}] {
+    return -1
+}
+
+if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile_1}" object {debug nowarnings additional_flags=-DFIRST} ] != "" } {
+     untested expand-psymtabs.exp
+     return -1
+}
+
+if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile_2}" object {debug nowarnings}] != "" } {
+     untested expand-psymtabs.exp
+     return -1
+}
+
+if  { [gdb_compile "${binfile_1} ${binfile_2}" "${binfile}" executable {debug nowarnings}] != "" } {
+     untested expand-psymtabs.exp
+     return -1
+}
+
+
+# use this to debug:
+log_user 1
+
+gdb_exit
+gdb_start
+gdb_reinitialize_dir $srcdir/$subdir
+gdb_load ${binfile}
+
+gdb_test "break 20" "Breakpoint.*" "Expand psymtabs"

[-- Attachment #3: expand-psymtabs-testcase.diff.sig --]
[-- Type: application/octet-stream, Size: 65 bytes --]

Re: [patch] Expand psymtabs when needed - testcase

[Daniel Jacobowitz]

On Tue, Dec 04, 2007 at 07:40:57PM -0200, Carlos Eduardo Seo wrote:
> Is this OK?

Almost, thanks.

> 2007-12-04  Carlos Eduardo Seo  <cseo@linux.vnet.ibm.com>
> 	    Jim Blandy  <jimb@codesourcery.com>
> 
> 	* testsuite/gdb.base/expand-psymtabs.c: New testcase 
> 	source file.
> 	* testsuite/gdb.base/expand-psymtabs.exp: New testcase
> 	expect file.

Since this goes in testsuite/ChangeLog, don't use the "testsuite/"
prefix in the entry.

> Index: src/gdb/testsuite/gdb.base/expand-psymtabs.c
> ===================================================================
> --- /dev/null
> +++ src/gdb/testsuite/gdb.base/expand-psymtabs.c
> @@ -0,0 +1,22 @@
> +#include <stdio.h>

Every new file should have a copyright notice, even in the testsuite.
Also, please avoid using I/O if you don't need it; that limits which
targets can run the test.

> +if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile_1}" object {debug nowarnings additional_flags=-DFIRST} ] != "" } {

Why nowarnings?

> +# use this to debug:
> +log_user 1

Delete this.

> +gdb_exit
> +gdb_start
> +gdb_reinitialize_dir $srcdir/$subdir
> +gdb_load ${binfile}
> +
> +gdb_test "break 20" "Breakpoint.*" "Expand psymtabs"

Don't use hardcoded line numbers.  Look for an example using
gdb_get_line_number instead to find the right line, unless there's
some reason that won't work.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [patch] Expand psymtabs when needed - testcase

[Carlos Eduardo Seo]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Daniel Jacobowitz wrote:
> On Tue, Dec 04, 2007 at 07:40:57PM -0200, Carlos Eduardo Seo wrote:
>> Is this OK?
> 
> Almost, thanks.
> 

Thanks for your review. I corrected everything you pointed out. I
believe it's OK now. :)

Regards,

- --
Carlos Eduardo Seo
Software Engineer
IBM Linux Technology Center
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHZccFqvq7Aov/qQARAr/TAJ9h6qw3H+fSybo0tKaVyLIg7VaoQwCfSXXN
4OLl4C03W/cwz5DyVgn5sz0=
=q+FM
-----END PGP SIGNATURE-----

[-- Attachment #2: expand-psymtabs-testcase.diff --]
[-- Type: text/x-patch, Size: 3461 bytes --]

2007-12-16  Carlos Eduardo Seo  <cseo@linux.vnet.ibm.com>
	    Jim Blandy  <jimb@codesourcery.com>

	* gdb.base/expand-psymtabs.c: New testcase 
	source file.
	* gdb.base/expand-psymtabs.exp: New testcase
	expect file.

Index: src-patched/gdb/testsuite/gdb.base/expand-psymtabs.c
===================================================================
--- /dev/null
+++ src-patched/gdb/testsuite/gdb.base/expand-psymtabs.c
@@ -0,0 +1,35 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2007 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+extern void foo (void);
+
+#ifdef FIRST
+int
+main (void)
+  {
+    foo ();
+    return 0;
+  }
+
+#else
+void
+foo (void)
+  {
+    /* Break here  */
+  }
+
+#endif
Index: src-patched/gdb/testsuite/gdb.base/expand-psymtabs.exp
===================================================================
--- /dev/null
+++ src-patched/gdb/testsuite/gdb.base/expand-psymtabs.exp
@@ -0,0 +1,58 @@
+# Copyright 2007 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+#
+# This file is part of the gdb testsuite.
+
+if $tracelevel then {
+    strace $tracelevel
+}
+
+# Test expanding partial symtabs when needed.
+
+set testfile expand-psymtabs
+set srcfile ${testfile}.c
+set binfile ${objdir}/${subdir}/${testfile}
+set binfile_1 ${objdir}/${subdir}/${testfile}_1.o
+set binfile_2 ${objdir}/${subdir}/${testfile}_2.o
+
+# What compiler are we using?
+if [get_compiler_info ${binfile}] {
+    return -1
+}
+
+if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile_1}" object {debug additional_flags=-DFIRST} ] != "" } {
+     untested expand-psymtabs.exp
+     return -1
+}
+
+if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile_2}" object {debug}] != "" } {
+     untested expand-psymtabs.exp
+     return -1
+}
+
+if  { [gdb_compile "${binfile_1} ${binfile_2}" "${binfile}" executable {debug}] != "" } {
+     untested expand-psymtabs.exp
+     return -1
+}
+
+gdb_exit
+gdb_start
+gdb_reinitialize_dir $srcdir/$subdir
+gdb_load ${binfile}
+
+set foo_bp [gdb_get_line_number "Break here"]
+gdb_test "break $foo_bp" "Breakpoint.*" "Expand psymtabs"
+

[-- Attachment #3: expand-psymtabs-testcase.diff.sig --]
[-- Type: application/octet-stream, Size: 65 bytes --]

Re: [patch] Expand psymtabs when needed - testcase

[Daniel Jacobowitz]

On Sun, Dec 16, 2007 at 10:47:01PM -0200, Carlos Eduardo Seo wrote:
> Thanks for your review. I corrected everything you pointed out. I
> believe it's OK now. :)

Me, too.  This is OK to check in.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [patch] Expand psymtabs when needed - testcase

[Thiago Jung Bauermann]

On Sun, 2007-12-16 at 22:47 -0200, Carlos Eduardo Seo wrote:
> > Almost, thanks.
> > 
> 
> Thanks for your review. I corrected everything you pointed out. I
> believe it's OK now. :)

Almost. :-))

> Index: src-patched/gdb/testsuite/gdb.base/expand-psymtabs.exp
> ===================================================================
> --- /dev/null
> +++ src-patched/gdb/testsuite/gdb.base/expand-psymtabs.exp
> @@ -0,0 +1,58 @@
> +# Copyright 2007 Free Software Foundation, Inc.
> +#
> +# This program is free software; you can redistribute it and/or
modify
> +# it under the terms of the GNU General Public License as published
by
> +# the Free Software Foundation; either version 2 of the License, or
> +# (at your option) any later version.

This should be GPL v3.
-- 
[]'s
Thiago Jung Bauermann
Software Engineer
IBM Linux Technology Center

Re: [patch] Expand psymtabs when needed - testcase

[Carlos Eduardo Seo]

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Thiago Jung Bauermann wrote:
> This should be GPL v3.

Corrected and checked in.

Thanks,

- --
Carlos Eduardo Seo
Software Engineer
IBM Linux Technology Center
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHZpBHqvq7Aov/qQARAkxMAJ4t6A41M2nhetUu15V+vxUrnRa8nwCggEKr
AqqTREW5aIQrYKdoT5333u4=
=SkRO
-----END PGP SIGNATURE-----

[-- Attachment #2: expand-psymtabs-testcase.diff --]
[-- Type: text/x-patch, Size: 3461 bytes --]

2007-12-16  Carlos Eduardo Seo  <cseo@linux.vnet.ibm.com>
	    Jim Blandy  <jimb@codesourcery.com>

	* gdb.base/expand-psymtabs.c: New testcase 
	source file.
	* gdb.base/expand-psymtabs.exp: New testcase
	expect file.

Index: src-patched/gdb/testsuite/gdb.base/expand-psymtabs.c
===================================================================
--- /dev/null
+++ src-patched/gdb/testsuite/gdb.base/expand-psymtabs.c
@@ -0,0 +1,35 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2007 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+extern void foo (void);
+
+#ifdef FIRST
+int
+main (void)
+  {
+    foo ();
+    return 0;
+  }
+
+#else
+void
+foo (void)
+  {
+    /* Break here  */
+  }
+
+#endif
Index: src-patched/gdb/testsuite/gdb.base/expand-psymtabs.exp
===================================================================
--- /dev/null
+++ src-patched/gdb/testsuite/gdb.base/expand-psymtabs.exp
@@ -0,0 +1,58 @@
+# Copyright 2007 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+#
+# This file is part of the gdb testsuite.
+
+if $tracelevel then {
+    strace $tracelevel
+}
+
+# Test expanding partial symtabs when needed.
+
+set testfile expand-psymtabs
+set srcfile ${testfile}.c
+set binfile ${objdir}/${subdir}/${testfile}
+set binfile_1 ${objdir}/${subdir}/${testfile}_1.o
+set binfile_2 ${objdir}/${subdir}/${testfile}_2.o
+
+# What compiler are we using?
+if [get_compiler_info ${binfile}] {
+    return -1
+}
+
+if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile_1}" object {debug additional_flags=-DFIRST} ] != "" } {
+     untested expand-psymtabs.exp
+     return -1
+}
+
+if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile_2}" object {debug}] != "" } {
+     untested expand-psymtabs.exp
+     return -1
+}
+
+if  { [gdb_compile "${binfile_1} ${binfile_2}" "${binfile}" executable {debug}] != "" } {
+     untested expand-psymtabs.exp
+     return -1
+}
+
+gdb_exit
+gdb_start
+gdb_reinitialize_dir $srcdir/$subdir
+gdb_load ${binfile}
+
+set foo_bp [gdb_get_line_number "Break here"]
+gdb_test "break $foo_bp" "Breakpoint.*" "Expand psymtabs"
+

[-- Attachment #3: expand-psymtabs-testcase.diff.sig --]
[-- Type: application/octet-stream, Size: 65 bytes --]