From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23509 invoked by alias); 17 Dec 2007 00:47:21 -0000 Received: (qmail 23500 invoked by uid 22791); 17 Dec 2007 00:47:20 -0000 X-Spam-Check-By: sourceware.org Received: from igw1.br.ibm.com (HELO igw1.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Dec 2007 00:47:07 +0000 Received: from mailhub1.br.ibm.com (mailhub1 [9.18.232.109]) by igw1.br.ibm.com (Postfix) with ESMTP id E034132C1B2 for ; Sun, 16 Dec 2007 22:27:35 -0200 (BRDT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id lBH0l3hP4092080 for ; Sun, 16 Dec 2007 22:47:03 -0200 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lBH0l2od029895 for ; Sun, 16 Dec 2007 22:47:03 -0200 Received: from [9.18.199.132] ([9.18.199.132]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id lBH0l2I3029892; Sun, 16 Dec 2007 22:47:02 -0200 Message-ID: <4765C705.3080504@linux.vnet.ibm.com> Date: Mon, 17 Dec 2007 00:56:00 -0000 From: Carlos Eduardo Seo User-Agent: Thunderbird 2.0.0.9 (X11/20071116) MIME-Version: 1.0 To: Daniel Jacobowitz CC: GDB Patches Mailing List Subject: Re: [patch] Expand psymtabs when needed - testcase References: <4755C969.6040001@linux.vnet.ibm.com> <20071216215352.GG2618@caradoc.them.org> In-Reply-To: <20071216215352.GG2618@caradoc.them.org> OpenPGP: id=8BFFA900 Content-Type: multipart/mixed; boundary="------------090304070708040002010604" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00247.txt.bz2 This is a multi-part message in MIME format. --------------090304070708040002010604 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 607 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Daniel Jacobowitz wrote: > On Tue, Dec 04, 2007 at 07:40:57PM -0200, Carlos Eduardo Seo wrote: >> Is this OK? > > Almost, thanks. > Thanks for your review. I corrected everything you pointed out. I believe it's OK now. :) Regards, - -- Carlos Eduardo Seo Software Engineer IBM Linux Technology Center -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHZccFqvq7Aov/qQARAr/TAJ9h6qw3H+fSybo0tKaVyLIg7VaoQwCfSXXN 4OLl4C03W/cwz5DyVgn5sz0= =q+FM -----END PGP SIGNATURE----- --------------090304070708040002010604 Content-Type: text/x-patch; name="expand-psymtabs-testcase.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="expand-psymtabs-testcase.diff" Content-length: 3461 2007-12-16 Carlos Eduardo Seo Jim Blandy * gdb.base/expand-psymtabs.c: New testcase source file. * gdb.base/expand-psymtabs.exp: New testcase expect file. Index: src-patched/gdb/testsuite/gdb.base/expand-psymtabs.c =================================================================== --- /dev/null +++ src-patched/gdb/testsuite/gdb.base/expand-psymtabs.c @@ -0,0 +1,35 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2007 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +extern void foo (void); + +#ifdef FIRST +int +main (void) + { + foo (); + return 0; + } + +#else +void +foo (void) + { + /* Break here */ + } + +#endif Index: src-patched/gdb/testsuite/gdb.base/expand-psymtabs.exp =================================================================== --- /dev/null +++ src-patched/gdb/testsuite/gdb.base/expand-psymtabs.exp @@ -0,0 +1,58 @@ +# Copyright 2007 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. +# +# This file is part of the gdb testsuite. + +if $tracelevel then { + strace $tracelevel +} + +# Test expanding partial symtabs when needed. + +set testfile expand-psymtabs +set srcfile ${testfile}.c +set binfile ${objdir}/${subdir}/${testfile} +set binfile_1 ${objdir}/${subdir}/${testfile}_1.o +set binfile_2 ${objdir}/${subdir}/${testfile}_2.o + +# What compiler are we using? +if [get_compiler_info ${binfile}] { + return -1 +} + +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile_1}" object {debug additional_flags=-DFIRST} ] != "" } { + untested expand-psymtabs.exp + return -1 +} + +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile_2}" object {debug}] != "" } { + untested expand-psymtabs.exp + return -1 +} + +if { [gdb_compile "${binfile_1} ${binfile_2}" "${binfile}" executable {debug}] != "" } { + untested expand-psymtabs.exp + return -1 +} + +gdb_exit +gdb_start +gdb_reinitialize_dir $srcdir/$subdir +gdb_load ${binfile} + +set foo_bp [gdb_get_line_number "Break here"] +gdb_test "break $foo_bp" "Breakpoint.*" "Expand psymtabs" + --------------090304070708040002010604 Content-Type: application/octet-stream; name="expand-psymtabs-testcase.diff.sig" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="expand-psymtabs-testcase.diff.sig" Content-length: 90 iD8DBQBHZccFqvq7Aov/qQARAtzNAJ4j84Y+u5J5xrRmfIztxYdIc+/GUQCe O1xSDZm0TBSyr8TQd6clTag1OxE= --------------090304070708040002010604--