From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-52712-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29476 invoked by alias); 16 Dec 2007 21:54:01 -0000
Received: (qmail 29468 invoked by uid 22791); 16 Dec 2007 21:54:00 -0000
X-Spam-Check-By: sourceware.org
Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 16 Dec 2007 21:53:54 +0000
Received: from nan.false.org (localhost [127.0.0.1]) 	by nan.false.org (Postfix) with ESMTP id 15D889814F; 	Sun, 16 Dec 2007 21:53:53 +0000 (GMT)
Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) 	by nan.false.org (Postfix) with ESMTP id EEE249811F; 	Sun, 16 Dec 2007 21:53:52 +0000 (GMT)
Received: from drow by caradoc.them.org with local (Exim 4.68) 	(envelope-from <drow@caradoc.them.org>) 	id 1J41Qm-0001IF-6P; Sun, 16 Dec 2007 16:53:52 -0500
Date: Sun, 16 Dec 2007 21:58:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
Cc: GDB Patches Mailing List <gdb-patches@sourceware.org>
Subject: Re: [patch] Expand psymtabs when needed - testcase
Message-ID: <20071216215352.GG2618@caradoc.them.org>
Mail-Followup-To: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>, 	GDB Patches Mailing List <gdb-patches@sourceware.org>
References: <4755C969.6040001@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4755C969.6040001@linux.vnet.ibm.com>
User-Agent: Mutt/1.5.17 (2007-12-11)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-12/txt/msg00234.txt.bz2

On Tue, Dec 04, 2007 at 07:40:57PM -0200, Carlos Eduardo Seo wrote:
> Is this OK?

Almost, thanks.

> 2007-12-04  Carlos Eduardo Seo  <cseo@linux.vnet.ibm.com>
> 	    Jim Blandy  <jimb@codesourcery.com>
> 
> 	* testsuite/gdb.base/expand-psymtabs.c: New testcase 
> 	source file.
> 	* testsuite/gdb.base/expand-psymtabs.exp: New testcase
> 	expect file.

Since this goes in testsuite/ChangeLog, don't use the "testsuite/"
prefix in the entry.

> Index: src/gdb/testsuite/gdb.base/expand-psymtabs.c
> ===================================================================
> --- /dev/null
> +++ src/gdb/testsuite/gdb.base/expand-psymtabs.c
> @@ -0,0 +1,22 @@
> +#include <stdio.h>

Every new file should have a copyright notice, even in the testsuite.
Also, please avoid using I/O if you don't need it; that limits which
targets can run the test.

> +if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile_1}" object {debug nowarnings additional_flags=-DFIRST} ] != "" } {

Why nowarnings?

> +# use this to debug:
> +log_user 1

Delete this.

> +gdb_exit
> +gdb_start
> +gdb_reinitialize_dir $srcdir/$subdir
> +gdb_load ${binfile}
> +
> +gdb_test "break 20" "Breakpoint.*" "Expand psymtabs"

Don't use hardcoded line numbers.  Look for an example using
gdb_get_line_number instead to find the right line, unless there's
some reason that won't work.

-- 
Daniel Jacobowitz
CodeSourcery