From: Markus Deuling <deuling@de.ibm.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] gdbserver async I/O simplifications
Date: Fri, 07 Dec 2007 07:29:00 -0000 [thread overview]
Message-ID: <4758EFA7.9070002@de.ibm.com> (raw)
In-Reply-To: <20071207014108.GA6743@caradoc.them.org>
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
Hi Daniel,
Daniel Jacobowitz schrieb:
> For the patch I'm working on, I needed asynchronous I/O to be disabled
> during start_inferior and it was ending up enabled. This version is
> considerably simpler, and does not have that problem. Async I/O can
> and should be enabled once we have received a packet that will take a
> long time, and must be disabled before we reply to GDB about it.
>
> Tested on x86_64-linux and committed.
>
it seems own_buf is missing in gdbserver/server.c (myresume). This fixes the build
but I havent tested it. Its just what I applied to my dev tree.
ChangeLog:
* gdbserver/server.c (myresume): Add own_buf variable.
--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com
[-- Attachment #2: fix-gdbsrv --]
[-- Type: text/plain, Size: 504 bytes --]
diff -urpN src/gdb/gdbserver/server.c dev/gdb/gdbserver/server.c
--- src/gdb/gdbserver/server.c 2007-12-07 06:32:33.000000000 +0100
+++ dev/gdb/gdbserver/server.c 2007-12-07 07:56:54.000000000 +0100
@@ -803,9 +803,11 @@ void
myresume (int step, int *signalp, char *statusp)
{
struct thread_resume resume_info[2];
+ char *own_buf;
int n = 0;
int sig = *signalp;
+ own_buf = malloc (PBUFSIZ + 1);
set_desired_inferior (0);
if (step || sig || (cont_thread != 0 && cont_thread != -1))
next prev parent reply other threads:[~2007-12-07 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-07 1:57 Daniel Jacobowitz
2007-12-07 7:29 ` Markus Deuling [this message]
2007-12-07 14:01 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4758EFA7.9070002@de.ibm.com \
--to=deuling@de.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox