Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Markus Deuling <deuling@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] gdbserver async I/O simplifications
Date: Fri, 07 Dec 2007 14:01:00 -0000	[thread overview]
Message-ID: <20071207140017.GA24131@caradoc.them.org> (raw)
In-Reply-To: <4758EFA7.9070002@de.ibm.com>

On Fri, Dec 07, 2007 at 08:00:55AM +0100, Markus Deuling wrote:
> Hi Daniel,
> 
> Daniel Jacobowitz schrieb:
> > For the patch I'm working on, I needed asynchronous I/O to be disabled
> > during start_inferior and it was ending up enabled.  This version is
> > considerably simpler, and does not have that problem.  Async I/O can
> > and should be enabled once we have received a packet that will take a
> > long time, and must be disabled before we reply to GDB about it.
> > Tested on x86_64-linux and committed.
> 
> it seems own_buf is missing in gdbserver/server.c (myresume). This fixes the 
> build
> but I havent tested it. Its just what I applied to my dev tree.
> 
> ChangeLog:
> 
> 	* gdbserver/server.c (myresume): Add own_buf variable.

I have apparently failed to test the patch I thought I was testing.
Fix checked in as below; tested, this time.

-- 
Daniel Jacobowitz
CodeSourcery

2007-12-07  Daniel Jacobowitz  <dan@codesourcery.com>

	* server.c (myresume): Add own_buf argument.
	(main): Update calls.

Index: server.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/server.c,v
retrieving revision 1.60
diff -u -p -r1.60 server.c
--- server.c	7 Dec 2007 01:41:29 -0000	1.60
+++ server.c	7 Dec 2007 13:47:09 -0000
@@ -800,7 +800,7 @@ handle_v_requests (char *own_buf, char *
 }
 
 void
-myresume (int step, int *signalp, char *statusp)
+myresume (char *own_buf, int step, int *signalp, char *statusp)
 {
   struct thread_resume resume_info[2];
   int n = 0;
@@ -1084,7 +1084,7 @@ main (int argc, char *argv[])
 		signal = target_signal_to_host (sig);
 	      else
 		signal = 0;
-	      myresume (0, &signal, &status);
+	      myresume (own_buf, 0, &signal, &status);
 	      break;
 	    case 'S':
 	      convert_ascii_to_int (own_buf + 1, &sig, 1);
@@ -1092,15 +1092,15 @@ main (int argc, char *argv[])
 		signal = target_signal_to_host (sig);
 	      else
 		signal = 0;
-	      myresume (1, &signal, &status);
+	      myresume (own_buf, 1, &signal, &status);
 	      break;
 	    case 'c':
 	      signal = 0;
-	      myresume (0, &signal, &status);
+	      myresume (own_buf, 0, &signal, &status);
 	      break;
 	    case 's':
 	      signal = 0;
-	      myresume (1, &signal, &status);
+	      myresume (own_buf, 1, &signal, &status);
 	      break;
 	    case 'Z':
 	      {


      reply	other threads:[~2007-12-07 14:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-07  1:57 Daniel Jacobowitz
2007-12-07  7:29 ` Markus Deuling
2007-12-07 14:01   ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071207140017.GA24131@caradoc.them.org \
    --to=drow@false.org \
    --cc=deuling@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox