From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24790 invoked by alias); 7 Dec 2007 14:00:46 -0000 Received: (qmail 24779 invoked by uid 22791); 7 Dec 2007 14:00:45 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 07 Dec 2007 14:00:19 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 0DB6698367; Fri, 7 Dec 2007 14:00:18 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id E40C5982D9; Fri, 7 Dec 2007 14:00:17 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1J0dkX-0000dQ-9y; Fri, 07 Dec 2007 09:00:17 -0500 Date: Fri, 07 Dec 2007 14:01:00 -0000 From: Daniel Jacobowitz To: Markus Deuling Cc: gdb-patches@sourceware.org Subject: Re: [commit] gdbserver async I/O simplifications Message-ID: <20071207140017.GA24131@caradoc.them.org> Mail-Followup-To: Markus Deuling , gdb-patches@sourceware.org References: <20071207014108.GA6743@caradoc.them.org> <4758EFA7.9070002@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4758EFA7.9070002@de.ibm.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00123.txt.bz2 On Fri, Dec 07, 2007 at 08:00:55AM +0100, Markus Deuling wrote: > Hi Daniel, > > Daniel Jacobowitz schrieb: > > For the patch I'm working on, I needed asynchronous I/O to be disabled > > during start_inferior and it was ending up enabled. This version is > > considerably simpler, and does not have that problem. Async I/O can > > and should be enabled once we have received a packet that will take a > > long time, and must be disabled before we reply to GDB about it. > > Tested on x86_64-linux and committed. > > it seems own_buf is missing in gdbserver/server.c (myresume). This fixes the > build > but I havent tested it. Its just what I applied to my dev tree. > > ChangeLog: > > * gdbserver/server.c (myresume): Add own_buf variable. I have apparently failed to test the patch I thought I was testing. Fix checked in as below; tested, this time. -- Daniel Jacobowitz CodeSourcery 2007-12-07 Daniel Jacobowitz * server.c (myresume): Add own_buf argument. (main): Update calls. Index: server.c =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/server.c,v retrieving revision 1.60 diff -u -p -r1.60 server.c --- server.c 7 Dec 2007 01:41:29 -0000 1.60 +++ server.c 7 Dec 2007 13:47:09 -0000 @@ -800,7 +800,7 @@ handle_v_requests (char *own_buf, char * } void -myresume (int step, int *signalp, char *statusp) +myresume (char *own_buf, int step, int *signalp, char *statusp) { struct thread_resume resume_info[2]; int n = 0; @@ -1084,7 +1084,7 @@ main (int argc, char *argv[]) signal = target_signal_to_host (sig); else signal = 0; - myresume (0, &signal, &status); + myresume (own_buf, 0, &signal, &status); break; case 'S': convert_ascii_to_int (own_buf + 1, &sig, 1); @@ -1092,15 +1092,15 @@ main (int argc, char *argv[]) signal = target_signal_to_host (sig); else signal = 0; - myresume (1, &signal, &status); + myresume (own_buf, 1, &signal, &status); break; case 'c': signal = 0; - myresume (0, &signal, &status); + myresume (own_buf, 0, &signal, &status); break; case 's': signal = 0; - myresume (1, &signal, &status); + myresume (own_buf, 1, &signal, &status); break; case 'Z': {