From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5104 invoked by alias); 7 Dec 2007 07:02:51 -0000 Received: (qmail 5073 invoked by uid 22791); 7 Dec 2007 07:02:50 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate8.de.ibm.com (HELO mtagate8.de.ibm.com) (195.212.29.157) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 07 Dec 2007 07:02:43 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate8.de.ibm.com (8.13.8/8.13.8) with ESMTP id lB772e5x360796 for ; Fri, 7 Dec 2007 07:02:40 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id lB772e0E1761416 for ; Fri, 7 Dec 2007 08:02:40 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lB772dat002403 for ; Fri, 7 Dec 2007 08:02:40 +0100 Received: from bbkeks.boeblingen.de.ibm.com (dyn-9-152-248-40.boeblingen.de.ibm.com [9.152.248.40]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id lB772cHV002390 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 7 Dec 2007 08:02:39 +0100 Message-ID: <4758EFA7.9070002@de.ibm.com> Date: Fri, 07 Dec 2007 07:29:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: Daniel Jacobowitz CC: gdb-patches@sourceware.org Subject: Re: [commit] gdbserver async I/O simplifications References: <20071207014108.GA6743@caradoc.them.org> In-Reply-To: <20071207014108.GA6743@caradoc.them.org> Content-Type: multipart/mixed; boundary="------------010807060607030500080900" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00119.txt.bz2 This is a multi-part message in MIME format. --------------010807060607030500080900 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 734 Hi Daniel, Daniel Jacobowitz schrieb: > For the patch I'm working on, I needed asynchronous I/O to be disabled > during start_inferior and it was ending up enabled. This version is > considerably simpler, and does not have that problem. Async I/O can > and should be enabled once we have received a packet that will take a > long time, and must be disabled before we reply to GDB about it. > > Tested on x86_64-linux and committed. > it seems own_buf is missing in gdbserver/server.c (myresume). This fixes the build but I havent tested it. Its just what I applied to my dev tree. ChangeLog: * gdbserver/server.c (myresume): Add own_buf variable. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------010807060607030500080900 Content-Type: text/plain; name="fix-gdbsrv" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="fix-gdbsrv" Content-length: 504 diff -urpN src/gdb/gdbserver/server.c dev/gdb/gdbserver/server.c --- src/gdb/gdbserver/server.c 2007-12-07 06:32:33.000000000 +0100 +++ dev/gdb/gdbserver/server.c 2007-12-07 07:56:54.000000000 +0100 @@ -803,9 +803,11 @@ void myresume (int step, int *signalp, char *statusp) { struct thread_resume resume_info[2]; + char *own_buf; int n = 0; int sig = *signalp; + own_buf = malloc (PBUFSIZ + 1); set_desired_inferior (0); if (step || sig || (cont_thread != 0 && cont_thread != -1)) --------------010807060607030500080900--