Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Lerele <lerele@champenstudios.com>
To: Pedro Alves <pedro_alves@portugalmail.pt>
Cc: gdb-patches@sourceware.org
Subject: Re: [win32] Fix suspend count handling
Date: Sat, 24 Nov 2007 14:21:00 -0000	[thread overview]
Message-ID: <47483362.3060805@champenstudios.com> (raw)
In-Reply-To: <47481C2F.4010009@portugalmail.pt>

Pedro Alves escribió:
> Lerele wrote:
>
>>
>> I'd also like to ask you a question, concerning a comment from Pedro 
>> several messages back that has stayed around in my mind since then.
>>
>> It's not related with this specific thread title, but since it's 
>> gdbserver/win32 related, I haven't found appropriate to open a new 
>> thread just for this simple question.
>>
>> The issue is near the end of:
>> http://sourceware.org/ml/gdb-patches/2007-11/msg00041.html
>>
>> It's about the fact of gdb win32-nat.c some time ago having the 
>> interrupt functionality similar to the one that has been recently 
>> implemented using SuspendThread (versus using DebugBreak kind of 
>> functions). Pedro commented back then that win32-nat.c did have 
>> sometime in the past a similar implementation [that must have been 
>> dropped].
>> Do you know/remember if it was dropped for a specific reason?
>>
>
> Humm, I guess I mistaked win32-nat.c for the winpdo-nat.c
> files on Apple's gdb:
>
> See in:
> http://www.opensource.apple.com/darwinsource/tarballs/other/gdb-186.1.tar.gz 
>
>
> In src/gdb-next/winpdo-nat.c, you'll see a SuspendThreads mechanism.
> The file header states 1996 as the latest copyright year, but they
> may have easilly failed to update it.  I'm not sure if win32-nat
> ever had this mechanism, or if it was only added by Apple.  Our
> cvs history only goes back till 1999.
>
> I did say: "I *think* that if...".  :-)
>

Sorry, I misunderstood "you'll see that once a similar method was used." 
as being an assertion.
Anyway there seems to be a reason not to SuspendThread, whether there 
was or wasn't such implementation in the past.

Leo.



  reply	other threads:[~2007-11-24 14:21 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-21  0:35 Pedro Alves
2007-11-21 11:25 ` Pierre Muller
2007-11-21 13:43   ` Pedro Alves
2007-11-21 14:13     ` Pierre Muller
2007-11-21 15:08       ` Pedro Alves
2007-11-21 15:32         ` Pierre Muller
2007-11-21 18:19         ` Pedro Alves
2007-11-21 23:33           ` Pedro Alves
2007-11-22  9:19             ` Pierre Muller
2007-11-23  1:07             ` Christopher Faylor
2007-11-23 10:19               ` Lerele
2007-11-23 18:30                 ` Lerele
2007-11-24 12:43                   ` Pedro Alves
2007-11-24 14:21                     ` Lerele [this message]
2007-11-24  5:33                 ` Christopher Faylor
2007-11-24 14:18                   ` Lerele
2007-11-24 15:49                     ` Pedro Alves
2007-11-24 17:50                       ` Lerele
2007-11-24 20:49                         ` Christopher Faylor
2007-11-24 20:48                     ` Christopher Faylor
2007-11-25 14:44                       ` Lerele
2007-11-25 18:13                         ` Christopher Faylor
2007-11-25 18:56                           ` Pedro Alves
2007-11-25 22:05                             ` Christopher Faylor
2007-11-25 22:13                               ` Lerele
2007-11-25 20:34                           ` Lerele
2007-11-24 12:16               ` Pedro Alves
2007-11-24 20:51                 ` Christopher Faylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47483362.3060805@champenstudios.com \
    --to=lerele@champenstudios.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro_alves@portugalmail.pt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox