Re: TUI + gdbserver broken?

[Denis PILAT <denis.pilat@st.com>]

Daniel Jacobowitz wrote:
> Thanks for all your detective work on this.  I'm sorry I apparently
> broke TUI so badly - I wish we had test coverage.
About TUI for Solaris, Fred and I have found where the problem comes 
from, but we are not sure about the fix.
A "new" call to solib_add in solib-svr4.c has been added 2006-10-18 (yes 
5 months ago!).
This call leads to a problem about the owner of the target_terminal, it 
seems that the TUI tries to write in the terminal without beein owner.

We tried just to add a call to "target_terminal_ours ()" at the 
beginning of infcmd.c (post_create_inferior), that fixes the problem.
But I guess it's not the good place to do that.

-- 
Denis

--- infcmd.c    27 Feb 2007 19:46:04 -0000      1.150
+++ infcmd.c    19 Mar 2007 15:57:34 -0000
@@ -406,6 +406,8 @@ tty_command (char *file, int from_tty)
 void
 post_create_inferior (struct target_ops *target, int from_tty)
 {
+  target_terminal_ours ();
+
   /* If the target hasn't taken care of this already, do it now.
      Targets which need to access registers during to_open,
      to_create_inferior, or to_attach should do it earlier; but many