From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro_alves@portugalmail.pt>
Cc: gdb-patches@sourceware.org
Subject: Re: TUI + gdbserver broken?
Date: Tue, 20 Mar 2007 02:56:00 -0000 [thread overview]
Message-ID: <20070320025548.GA6238@caradoc.them.org> (raw)
In-Reply-To: <45FF2D16.6030501@portugalmail.pt>
On Tue, Mar 20, 2007 at 12:38:46AM +0000, Pedro Alves wrote:
> How about the attached? Move the selected_frame creation logic
> to select_frame.
> It fixes both the remote debugging problem, and the repainting
> problems - probably caused by the get_selected_frame calling
> select_frame generating extra spurious events.
> It would need a testsuite run and a bit of cleanup, since the
> get_selected_frame would lose the parameter.
Please don't. The comment you're deleting in get_selected_frame is
very important:
- /* There is always a frame. */
Andrew went to a lot of work making this true, and we now assume it
all over the place. Every caller of get_selected_frame now assumes it
returns a valid frame.
If you're stuck tracking down what TUI is doing on Cygwin, I will
compare this with Denis's findings and see what happens on Linux.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-03-20 2:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 1:53 Pedro Alves
2007-03-19 2:11 ` Daniel Jacobowitz
2007-03-19 15:58 ` Denis PILAT
2007-03-27 20:09 ` Daniel Jacobowitz
2007-04-17 15:48 ` [RFA] TUI is broken under Solaris Denis PILAT
2007-04-17 15:51 ` Daniel Jacobowitz
2007-04-18 8:24 ` Denis PILAT
2007-03-19 21:43 ` TUI + gdbserver broken? Pedro Alves
2007-03-19 22:14 ` Daniel Jacobowitz
2007-03-19 23:31 ` Pedro Alves
2007-03-19 23:41 ` Daniel Jacobowitz
2007-03-20 0:39 ` Pedro Alves
2007-03-20 2:56 ` Daniel Jacobowitz [this message]
2007-03-20 9:05 ` Pedro Alves
2007-03-20 23:21 ` Pedro Alves
2007-03-22 2:51 ` Pedro Alves
2007-03-27 20:15 ` Daniel Jacobowitz
2007-03-29 2:26 ` Pedro Alves
2007-03-29 18:55 ` Daniel Jacobowitz
[not found] <45F7480C.5010207@portugalmail.pt>
2007-03-14 8:29 ` Denis PILAT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070320025548.GA6238@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro_alves@portugalmail.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox