From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4020 invoked by alias); 20 Mar 2007 02:56:02 -0000 Received: (qmail 3987 invoked by uid 22791); 20 Mar 2007 02:55:58 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 20 Mar 2007 02:55:51 +0000 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 2B1E74B267; Mon, 19 Mar 2007 21:55:50 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 005B74B262; Mon, 19 Mar 2007 21:55:49 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HTUVp-0001cv-0Q; Mon, 19 Mar 2007 22:55:49 -0400 Date: Tue, 20 Mar 2007 02:56:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: TUI + gdbserver broken? Message-ID: <20070320025548.GA6238@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <45FDECB3.5000002@portugalmail.pt> <20070319021145.GA25872@caradoc.them.org> <45FEF7B0.9070209@portugalmail.pt> <20070319221430.GA24326@caradoc.them.org> <45FF1571.2080401@portugalmail.pt> <20070319234141.GA29137@caradoc.them.org> <45FF2D16.6030501@portugalmail.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45FF2D16.6030501@portugalmail.pt> User-Agent: Mutt/1.5.14+cvs20070313 (2007-03-13) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00179.txt.bz2 On Tue, Mar 20, 2007 at 12:38:46AM +0000, Pedro Alves wrote: > How about the attached? Move the selected_frame creation logic > to select_frame. > It fixes both the remote debugging problem, and the repainting > problems - probably caused by the get_selected_frame calling > select_frame generating extra spurious events. > It would need a testsuite run and a bit of cleanup, since the > get_selected_frame would lose the parameter. Please don't. The comment you're deleting in get_selected_frame is very important: - /* There is always a frame. */ Andrew went to a lot of work making this true, and we now assume it all over the place. Every caller of get_selected_frame now assumes it returns a valid frame. If you're stuck tracking down what TUI is doing on Cygwin, I will compare this with Denis's findings and see what happens on Linux. -- Daniel Jacobowitz CodeSourcery