From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8869 invoked by alias); 19 Mar 2007 15:58:59 -0000 Received: (qmail 8860 invoked by uid 22791); 19 Mar 2007 15:58:58 -0000 X-Spam-Check-By: sourceware.org Received: from lon-del-01.spheriq.net (HELO lon-del-01.spheriq.net) (195.46.50.97) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 19 Mar 2007 15:58:54 +0000 Received: from lon-out-02.spheriq.net ([195.46.50.130]) by lon-del-01.spheriq.net with ESMTP id l2JFwVt4022420 for ; Mon, 19 Mar 2007 15:58:31 GMT Received: from lon-cus-02.spheriq.net (lon-cus-02.spheriq.net [195.46.50.38]) by lon-out-02.spheriq.net with ESMTP id l2JFwUUg003428 for ; Mon, 19 Mar 2007 15:58:30 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by lon-cus-02.spheriq.net with ESMTP id l2JFwTCp007444 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 19 Mar 2007 15:58:30 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id D5C6FDA4E; Mon, 19 Mar 2007 15:58:24 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 742A7477D7; Mon, 19 Mar 2007 15:58:24 +0000 (GMT) Received: from [164.129.44.95] (crx595.cro.st.com [164.129.44.95]) by mail1.cro.st.com (MOS 3.7.5a-GA) with ESMTP id CKA09888 (AUTH "denis pilat"); Mon, 19 Mar 2007 16:58:23 +0100 (CET) Message-ID: <45FEB31F.6040503@st.com> Date: Mon, 19 Mar 2007 15:58:00 -0000 From: Denis PILAT User-Agent: Thunderbird 1.5.0.10 (X11/20070221) MIME-Version: 1.0 To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: TUI + gdbserver broken? References: <45FDECB3.5000002@portugalmail.pt> <20070319021145.GA25872@caradoc.them.org> In-Reply-To: <20070319021145.GA25872@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00169.txt.bz2 Daniel Jacobowitz wrote: > Thanks for all your detective work on this. I'm sorry I apparently > broke TUI so badly - I wish we had test coverage. About TUI for Solaris, Fred and I have found where the problem comes from, but we are not sure about the fix. A "new" call to solib_add in solib-svr4.c has been added 2006-10-18 (yes 5 months ago!). This call leads to a problem about the owner of the target_terminal, it seems that the TUI tries to write in the terminal without beein owner. We tried just to add a call to "target_terminal_ours ()" at the beginning of infcmd.c (post_create_inferior), that fixes the problem. But I guess it's not the good place to do that. -- Denis --- infcmd.c 27 Feb 2007 19:46:04 -0000 1.150 +++ infcmd.c 19 Mar 2007 15:57:34 -0000 @@ -406,6 +406,8 @@ tty_command (char *file, int from_tty) void post_create_inferior (struct target_ops *target, int from_tty) { + target_terminal_ours (); + /* If the target hasn't taken care of this already, do it now. Targets which need to access registers during to_open, to_create_inferior, or to_attach should do it earlier; but many