From: Markus Deuling <deuling@de.ibm.com>
To: GDB Patches <gdb-patches@sourceware.org>
Subject: [RFA] gdbserver/server.c: Replace 2x strlen() by a variable
Date: Thu, 21 Dec 2006 07:45:00 -0000 [thread overview]
Message-ID: <458A3B6C.2040803@de.ibm.com> (raw)
Hello,
this little patch adds a variable to prevent strlen() from being called two times.
Maybe it would also be a good idea to replace it by the hard-coded length, but I think
the code then will be less readable then.
Is it ok to apply ?
ChangeLog:
* server.c (handle_general_set): New variable len instead
of using strlen two times.
=========================================
diff -urN src/gdb/gdbserver/server.c dev/gdb/gdbserver/server.c
--- src/gdb/gdbserver/server.c 2006-12-21 08:38:11.000000000 +0100
+++ dev/gdb/gdbserver/server.c 2006-12-21 08:38:25.000000000 +0100
@@ -163,10 +163,11 @@
void
handle_general_set (char *own_buf)
{
- if (strncmp ("QPassSignals:", own_buf, strlen ("QPassSignals:")) == 0)
+ int len = strlen ("QPassSignals:");
+ if (strncmp ("QPassSignals:", own_buf, len) == 0)
{
int numsigs = (int) TARGET_SIGNAL_LAST, i;
- const char *p = own_buf + strlen ("QPassSignals:");
+ const char *p = own_buf + len;
CORE_ADDR cursig;
p = decode_address_to_semicolon (&cursig, p);
Regards,
Markus
--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com
next reply other threads:[~2006-12-21 7:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-21 7:45 Markus Deuling [this message]
2006-12-21 11:08 ` Joel Brobecker
2006-12-21 11:48 ` Andreas Schwab
2006-12-21 12:47 ` Mark Kettenis
2006-12-21 13:04 ` Joel Brobecker
2006-12-26 15:35 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=458A3B6C.2040803@de.ibm.com \
--to=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox