From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4950 invoked by alias); 21 Dec 2006 07:45:00 -0000 Received: (qmail 4936 invoked by uid 22791); 21 Dec 2006 07:44:58 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 21 Dec 2006 07:44:49 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.8/8.13.8) with ESMTP id kBL7ikxM205848 for ; Thu, 21 Dec 2006 07:44:46 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id kBL7ijHn3018922 for ; Thu, 21 Dec 2006 08:44:46 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id kBL7iju9018793 for ; Thu, 21 Dec 2006 08:44:45 +0100 Received: from [9.152.248.39] (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id kBL7ijC5018780 for ; Thu, 21 Dec 2006 08:44:45 +0100 Message-ID: <458A3B6C.2040803@de.ibm.com> Date: Thu, 21 Dec 2006 07:45:00 -0000 From: Markus Deuling User-Agent: Thunderbird 1.5.0.8 (X11/20061107) MIME-Version: 1.0 To: GDB Patches Subject: [RFA] gdbserver/server.c: Replace 2x strlen() by a variable Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00281.txt.bz2 Hello, this little patch adds a variable to prevent strlen() from being called two times. Maybe it would also be a good idea to replace it by the hard-coded length, but I think the code then will be less readable then. Is it ok to apply ? ChangeLog: * server.c (handle_general_set): New variable len instead of using strlen two times. ========================================= diff -urN src/gdb/gdbserver/server.c dev/gdb/gdbserver/server.c --- src/gdb/gdbserver/server.c 2006-12-21 08:38:11.000000000 +0100 +++ dev/gdb/gdbserver/server.c 2006-12-21 08:38:25.000000000 +0100 @@ -163,10 +163,11 @@ void handle_general_set (char *own_buf) { - if (strncmp ("QPassSignals:", own_buf, strlen ("QPassSignals:")) == 0) + int len = strlen ("QPassSignals:"); + if (strncmp ("QPassSignals:", own_buf, len) == 0) { int numsigs = (int) TARGET_SIGNAL_LAST, i; - const char *p = own_buf + strlen ("QPassSignals:"); + const char *p = own_buf + len; CORE_ADDR cursig; p = decode_address_to_semicolon (&cursig, p); Regards, Markus -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com