From: Andreas Schwab <schwab@suse.de>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Markus Deuling <deuling@de.ibm.com>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] gdbserver/server.c: Replace 2x strlen() by a variable
Date: Thu, 21 Dec 2006 11:48:00 -0000 [thread overview]
Message-ID: <jemz5hqxlh.fsf@sykes.suse.de> (raw)
In-Reply-To: <20061221110904.GG3640@adacore.com> (Joel Brobecker's message of "Thu, 21 Dec 2006 15:09:04 +0400")
Joel Brobecker <brobecker@adacore.com> writes:
>> ChangeLog:
>>
>> * server.c (handle_general_set): New variable len instead
>> of using strlen two times.
>
> Actually, since the same string is duplicated a couple of times,
> I would also suggest declaring a constant string "QPassSignals:"
> and use the constant instead of risking a typo... How about:
>
> const char str[] = "QPassSignals:";
Or just define it as a macro.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2006-12-21 11:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-21 7:45 Markus Deuling
2006-12-21 11:08 ` Joel Brobecker
2006-12-21 11:48 ` Andreas Schwab [this message]
2006-12-21 12:47 ` Mark Kettenis
2006-12-21 13:04 ` Joel Brobecker
2006-12-26 15:35 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jemz5hqxlh.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=brobecker@adacore.com \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox