PATCH: Add missing Morpho coprocessor registers

PATCH: Add missing Morpho coprocessor registers

[Mark Mitchell]

This patch adds a few missing registers to the MT port.

OK to apply?

Thanks,  

--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

2006-04-18  Mark Mitchell  <mark@codesourcery.com>

	* mt-tdep.c (mt_gdb_regnums): Add ZI2, ZQ2, Ichannel2,
	Iscramb2, Qscramb2, Qchannel2.
	(mt_register_name): Likewise.
	(mt_copro_register_type): Describe ZI2 and ZQ2.
	
Index: mt-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mt-tdep.c,v
retrieving revision 1.4.2.1
diff -c -5 -p -r1.4.2.1 mt-tdep.c
*** mt-tdep.c	12 Apr 2006 03:22:29 -0000	1.4.2.1
--- mt-tdep.c	19 Apr 2006 04:46:23 -0000
*************** enum mt_gdb_regnums
*** 107,116 ****
--- 107,122 ----
    MT_ISCRAMB_REGNUM,		/* 32 bits.  */
    MT_QSCRAMB_REGNUM,		/* 32 bits.  */
    MT_OUT_REGNUM,			/* 16 bits.  */
    MT_EXMAC_REGNUM,		/* 32 bits (8 used).  */
    MT_QCHANNEL_REGNUM,		/* 32 bits.  */
+   MT_ZI2_REGNUM,                /* 16 bits.  */
+   MT_ZQ2_REGNUM,                /* 16 bits.  */
+   MT_CHANNEL2_REGNUM,           /* 32 bits.  */
+   MT_ISCRAMB2_REGNUM,           /* 32 bits.  */
+   MT_QSCRAMB2_REGNUM,           /* 32 bits.  */
+   MT_QCHANNEL2_REGNUM,          /* 32 bits.  */
  
    /* Number of real registers.  */
    MT_NUM_REGS,
  
    /* Pseudo-registers.  */
*************** mt_register_name (int regnum)
*** 147,156 ****
--- 153,163 ----
      "",				/* copro register.  */
      "cr0", "cr1", "cr2", "cr3", "cr4", "cr5", "cr6", "cr7",
      "cr8", "cr9", "cr10", "cr11", "cr12", "cr13", "cr14", "cr15",
      "bypa", "bypb", "bypc", "flag", "context", "" /* mac.  */ , "z1", "z2",
      "Ichannel", "Iscramb", "Qscramb", "out", "" /* ex-mac.  */ , "Qchannel",
+     "zi2", "zq2", "Ichannel2", "Iscramb2", "Qscramb2", "Qchannel2",
      /* Pseudo-registers.  */
      "coprocessor", "MAC"
    };
    static const char *array_names[MT_COPRO_PSEUDOREG_REGS
  				 * MT_COPRO_PSEUDOREG_DIM_1
*************** mt_copro_register_type (struct gdbarch *
*** 211,220 ****
--- 218,229 ----
      case MT_BYPB_REGNUM:
      case MT_BYPC_REGNUM:
      case MT_Z1_REGNUM:
      case MT_Z2_REGNUM:
      case MT_OUT_REGNUM:
+     case MT_ZI2_REGNUM:
+     case MT_ZQ2_REGNUM:
        return builtin_type_int16;
      case MT_EXMAC_REGNUM:
      case MT_MAC_REGNUM:
        return builtin_type_uint32;
      case MT_CONTEXT_REGNUM:

Re: PATCH: Add missing Morpho coprocessor registers

[Kevin Buettner]

On Tue, 18 Apr 2006 21:57:58 -0700
Mark Mitchell <mark@codesourcery.com> wrote:

> This patch adds a few missing registers to the MT port.
> 
> OK to apply?

Am I still the maintainer for this?  (The MAINTAINERS file says that I'm
maintainer for ms1, but says nothing about mt.  Also, I see no ChangeLog
entry which says when ms1-tdep.c was changed to mt-tdep.c.)

Anyway, this change is okay with me.

Kevin

Re: PATCH: Add missing Morpho coprocessor registers

[Daniel Jacobowitz]

On Wed, Apr 19, 2006 at 03:24:25PM -0700, Kevin Buettner wrote:
> On Tue, 18 Apr 2006 21:57:58 -0700
> Mark Mitchell <mark@codesourcery.com> wrote:
> 
> > This patch adds a few missing registers to the MT port.
> > 
> > OK to apply?
> 
> Am I still the maintainer for this?  (The MAINTAINERS file says that I'm
> maintainer for ms1, but says nothing about mt.  Also, I see no ChangeLog
> entry which says when ms1-tdep.c was changed to mt-tdep.c.)

Dunno how that happened; but it's certainly the same port - I'd
recommend the obvious fix to MAINTAINERS!

-- 
Daniel Jacobowitz
CodeSourcery

Re: PATCH: Add missing Morpho coprocessor registers

[Michael Snyder]

Daniel Jacobowitz wrote:
> On Wed, Apr 19, 2006 at 03:24:25PM -0700, Kevin Buettner wrote:
> 
>>On Tue, 18 Apr 2006 21:57:58 -0700
>>Mark Mitchell <mark@codesourcery.com> wrote:
>>
>>
>>>This patch adds a few missing registers to the MT port.
>>>
>>>OK to apply?
>>
>>Am I still the maintainer for this?  (The MAINTAINERS file says that I'm
>>maintainer for ms1, but says nothing about mt.  Also, I see no ChangeLog
>>entry which says when ms1-tdep.c was changed to mt-tdep.c.)
> 
> 
> Dunno how that happened; but it's certainly the same port - I'd
> recommend the obvious fix to MAINTAINERS!
> 

Should we mention the change in NEWS?

Re: PATCH: Add missing Morpho coprocessor registers

[Eli Zaretskii]

> Date: Thu, 20 Apr 2006 16:05:27 -0700
> From: Michael Snyder <msnyder@redhat.com>
> CC: gdb-patches@sourceware.org
> 
> Should we mention the change in NEWS?

If the added feature is something to die for, then yes.  But if
normally users don't care about these registers, then it isn't
important enough to be in NEWS.

Re: PATCH: Add missing Morpho coprocessor registers

[Michael Snyder]

Eli Zaretskii wrote:
>>Date: Thu, 20 Apr 2006 16:05:27 -0700
>>From: Michael Snyder <msnyder@redhat.com>
>>CC: gdb-patches@sourceware.org
>>
>>Should we mention the change in NEWS?
> 
> 
> If the added feature is something to die for, then yes.  But if
> normally users don't care about these registers, then it isn't
> important enough to be in NEWS.

I was more thinking about the change in target architecture name,
form ms1 to mt.

Re: PATCH: Add missing Morpho coprocessor registers

[Eli Zaretskii]

> Date: Fri, 21 Apr 2006 11:50:00 -0700
> From: Michael Snyder <msnyder@redhat.com>
> CC: drow@false.org, gdb-patches@sourceware.org
> 
> I was more thinking about the change in target architecture name,
> form ms1 to mt.

Yes, that should be in NEWS.