[PATCH] Add support for Analog Devices Blackfin processor (part 6/6: src toplevel)

[PATCH] Add support for Analog Devices Blackfin processor (part 6/6: src toplevel)

[Jie Zhang]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

This final part only contains one line change in src top level
configure, which will enable configure in gdb directory for bfin port.

Any comments?

Thanks,
Jie


[-- Attachment #2: bfin-toplevel.diff --]
[-- Type: text/x-patch, Size: 563 bytes --]


	* configure: Configure gdb directory for bfin.

diff -u src.orig/configure src/configure
--- src.orig/configure	2005-12-27 13:36:54.000000000 +0800
+++ src/configure	2005-12-27 10:23:42.000000000 +0800
@@ -1293,7 +1293,7 @@
     noconfigdirs="$noconfigdirs target-libiberty target-libstdc++-v3 ${libgcj}"
     ;;
   bfin-*-*)
-    noconfigdirs="$noconfigdirs target-libgloss gdb"
+    noconfigdirs="$noconfigdirs target-libgloss"
     if test x${is_cross_compiler} != xno ; then
       target_configdirs="${target_configdirs} target-bsp target-cygmon"
     fi

Re: [PATCH] Add support for Analog Devices Blackfin processor (part 6/6: src toplevel)

[Jim Blandy]

On 12/27/05, Jie Zhang <jzhang918@gmail.com> wrote:
> This final part only contains one line change in src top level
> configure, which will enable configure in gdb directory for bfin port.

I think you want to post a patch to configure.in, not configure. 
(It's preferred to omit the patches to configure scripts generated
from configure.in or configure.ac files when posting work for review.)
 And the patch needs to go to binutils@sources.redhat.com, as well as
gdb-patches.

The actual content of the change looks straightforward to me.

Re: [PATCH] Add support for Analog Devices Blackfin processor (part 6/6: src toplevel)

[Jie Zhang]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

On 1/4/06, Jim Blandy <jimb@red-bean.com> wrote:
> On 12/27/05, Jie Zhang <jzhang918@gmail.com> wrote:
> > This final part only contains one line change in src top level
> > configure, which will enable configure in gdb directory for bfin port.
>
> I think you want to post a patch to configure.in, not configure.
> (It's preferred to omit the patches to configure scripts generated
> from configure.in or configure.ac files when posting work for review.)
>  And the patch needs to go to binutils@sources.redhat.com, as well as
> gdb-patches.
>
Here is the second patch, which is for configure.in, and also sent to
binutils@sources.redhat.com. Sorry for not sending the first one to
binutils mailing list.

> The actual content of the change looks straightforward to me.
>
If it's also OK for binutils, I'll commit it along with other Blackfin
gdb patches.

Thanks,
Jie

[-- Attachment #2: bfin-toplevel-2.diff --]
[-- Type: text/x-patch, Size: 528 bytes --]


	* configure.in: Configure gdb directory for bfin.

--- src.orig/configure.in	2006-01-04 15:04:05.000000000 +0800
+++ src/configure.in	2006-01-04 15:02:16.000000000 +0800
@@ -501,7 +501,7 @@
     noconfigdirs="$noconfigdirs target-libiberty target-libstdc++-v3 ${libgcj}"
     ;;
   bfin-*-*)
-    noconfigdirs="$noconfigdirs target-libgloss gdb"
+    noconfigdirs="$noconfigdirs target-libgloss"
     if test x${is_cross_compiler} != xno ; then
       target_configdirs="${target_configdirs} target-bsp target-cygmon"
     fi

Re: [PATCH] Add support for Analog Devices Blackfin processor (part 6/6: src toplevel)

[Nick Clifton]

Hi Jie,

> Here is the second patch, which is for configure.in, and also sent to
> binutils@sources.redhat.com. Sorry for not sending the first one to
> binutils mailing list.
> 
>> The actual content of the change looks straightforward to me.
>>
> If it's also OK for binutils, I'll commit it along with other Blackfin
> gdb patches.

It is OK for binutils.

Cheers
   Nick

Re: [PATCH] Add support for Analog Devices Blackfin processor (part 6/6: src toplevel)

[Daniel Jacobowitz]

On Wed, Jan 04, 2006 at 03:15:56PM +0800, Jie Zhang wrote:
> On 1/4/06, Jim Blandy <jimb@red-bean.com> wrote:
> > On 12/27/05, Jie Zhang <jzhang918@gmail.com> wrote:
> > > This final part only contains one line change in src top level
> > > configure, which will enable configure in gdb directory for bfin port.
> >
> > I think you want to post a patch to configure.in, not configure.
> > (It's preferred to omit the patches to configure scripts generated
> > from configure.in or configure.ac files when posting work for review.)
> >  And the patch needs to go to binutils@sources.redhat.com, as well as
> > gdb-patches.
> >
> Here is the second patch, which is for configure.in, and also sent to
> binutils@sources.redhat.com. Sorry for not sending the first one to
> binutils mailing list.
> 
> > The actual content of the change looks straightforward to me.
> >
> If it's also OK for binutils, I'll commit it along with other Blackfin
> gdb patches.

Sounds good.

> 	* configure.in: Configure gdb directory for bfin.

You may already know this, but you should also mention the generated
files in the changelog:

	* configure: Regenerated.

And commit both.

-- 
Daniel Jacobowitz
CodeSourcery