Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Jie Zhang <jzhang918@gmail.com>
Cc: Jim Blandy <jimb@red-bean.com>,
	binutils@sources.redhat.com, 	gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Add support for Analog Devices Blackfin processor (part 6/6: src toplevel)
Date: Fri, 20 Jan 2006 23:25:00 -0000	[thread overview]
Message-ID: <20060120232527.GI21181@nevyn.them.org> (raw)
In-Reply-To: <6f48278f0601032315p2038610fw740d7a2c8a420700@mail.gmail.com>

On Wed, Jan 04, 2006 at 03:15:56PM +0800, Jie Zhang wrote:
> On 1/4/06, Jim Blandy <jimb@red-bean.com> wrote:
> > On 12/27/05, Jie Zhang <jzhang918@gmail.com> wrote:
> > > This final part only contains one line change in src top level
> > > configure, which will enable configure in gdb directory for bfin port.
> >
> > I think you want to post a patch to configure.in, not configure.
> > (It's preferred to omit the patches to configure scripts generated
> > from configure.in or configure.ac files when posting work for review.)
> >  And the patch needs to go to binutils@sources.redhat.com, as well as
> > gdb-patches.
> >
> Here is the second patch, which is for configure.in, and also sent to
> binutils@sources.redhat.com. Sorry for not sending the first one to
> binutils mailing list.
> 
> > The actual content of the change looks straightforward to me.
> >
> If it's also OK for binutils, I'll commit it along with other Blackfin
> gdb patches.

Sounds good.

> 	* configure.in: Configure gdb directory for bfin.

You may already know this, but you should also mention the generated
files in the changelog:

	* configure: Regenerated.

And commit both.

-- 
Daniel Jacobowitz
CodeSourcery


      parent reply	other threads:[~2006-01-20 23:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-30 12:13 Jie Zhang
2006-01-04  5:39 ` Jim Blandy
2006-01-04  7:16   ` Jie Zhang
2006-01-09 15:41     ` Nick Clifton
2006-01-20 23:25     ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060120232527.GI21181@nevyn.them.org \
    --to=drow@false.org \
    --cc=binutils@sources.redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@red-bean.com \
    --cc=jzhang918@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox