From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1503 invoked by alias); 20 Jan 2006 23:25:34 -0000 Received: (qmail 1460 invoked by uid 22791); 20 Jan 2006 23:25:33 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 20 Jan 2006 23:25:30 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1F05dH-0005lF-1f; Fri, 20 Jan 2006 18:25:27 -0500 Date: Fri, 20 Jan 2006 23:25:00 -0000 From: Daniel Jacobowitz To: Jie Zhang Cc: Jim Blandy , binutils@sources.redhat.com, gdb-patches@sources.redhat.com Subject: Re: [PATCH] Add support for Analog Devices Blackfin processor (part 6/6: src toplevel) Message-ID: <20060120232527.GI21181@nevyn.them.org> Mail-Followup-To: Jie Zhang , Jim Blandy , binutils@sources.redhat.com, gdb-patches@sources.redhat.com References: <43B160B0.9000203@gmail.com> <8f2776cb0601032139u24a10ebapcda0e8294037cbde@mail.gmail.com> <6f48278f0601032315p2038610fw740d7a2c8a420700@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6f48278f0601032315p2038610fw740d7a2c8a420700@mail.gmail.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00265.txt.bz2 On Wed, Jan 04, 2006 at 03:15:56PM +0800, Jie Zhang wrote: > On 1/4/06, Jim Blandy wrote: > > On 12/27/05, Jie Zhang wrote: > > > This final part only contains one line change in src top level > > > configure, which will enable configure in gdb directory for bfin port. > > > > I think you want to post a patch to configure.in, not configure. > > (It's preferred to omit the patches to configure scripts generated > > from configure.in or configure.ac files when posting work for review.) > > And the patch needs to go to binutils@sources.redhat.com, as well as > > gdb-patches. > > > Here is the second patch, which is for configure.in, and also sent to > binutils@sources.redhat.com. Sorry for not sending the first one to > binutils mailing list. > > > The actual content of the change looks straightforward to me. > > > If it's also OK for binutils, I'll commit it along with other Blackfin > gdb patches. Sounds good. > * configure.in: Configure gdb directory for bfin. You may already know this, but you should also mention the generated files in the changelog: * configure: Regenerated. And commit both. -- Daniel Jacobowitz CodeSourcery