PATCH comment in infrun.c

PATCH comment in infrun.c

[Ben Elliston]

[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]

I'm reasonably sure this comment no longer applies.  Okay for mainline?

2005-05-02  Ben Elliston  <bje@au.ibm.com>

	* infrun.c (handle_inferior_event): Remove comment from 2003-03-28
	that is no longer valid.

Index: infrun.c
===================================================================
RCS file: /home/bje/src-cvs/src/gdb/infrun.c,v
retrieving revision 1.199
diff -u -p -r1.199 infrun.c
--- infrun.c    24 Feb 2005 13:51:32 -0000      1.199
+++ infrun.c    2 May 2005 06:00:00 -0000
@@ -1233,11 +1233,6 @@ int stepped_after_stopped_by_watchpoint;
 void
 handle_inferior_event (struct execution_control_state *ecs)
 {
-  /* NOTE: cagney/2003-03-28: If you're looking at this code and
-     thinking that the variable stepped_after_stopped_by_watchpoint
-     isn't used, then you're wrong!  The macro STOPPED_BY_WATCHPOINT,
-     defined in the file "config/pa/nm-hppah.h", accesses the variable
-     indirectly.  Mutter something rude about the HP merge.  */
   int sw_single_step_trap_p = 0;
   int stopped_by_watchpoint = -1;      /* Mark as unknown.  */


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]

Re: PATCH comment in infrun.c

[Daniel Jacobowitz]

On Mon, May 02, 2005 at 04:00:11PM +1000, Ben Elliston wrote:
> I'm reasonably sure this comment no longer applies.  Okay for mainline?
> 
> 2005-05-02  Ben Elliston  <bje@au.ibm.com>
> 
> 	* infrun.c (handle_inferior_event): Remove comment from 2003-03-28
> 	that is no longer valid.

It needs updating, not removal; there's still a reference in remote.c.

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: PATCH comment in infrun.c

[Ben Elliston]

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

> It needs updating, not removal; there's still a reference in remote.c.

Better?

Index: infrun.c
===================================================================
RCS file: /home/bje/src-cvs/src/gdb/infrun.c,v
retrieving revision 1.199
diff -u -p -r1.199 infrun.c
--- infrun.c    24 Feb 2005 13:51:32 -0000      1.199
+++ infrun.c    2 May 2005 23:41:23 -0000
@@ -1233,11 +1233,10 @@ int stepped_after_stopped_by_watchpoint;
 void
 handle_inferior_event (struct execution_control_state *ecs)
 {
-  /* NOTE: cagney/2003-03-28: If you're looking at this code and
-     thinking that the variable stepped_after_stopped_by_watchpoint
-     isn't used, then you're wrong!  The macro STOPPED_BY_WATCHPOINT,
-     defined in the file "config/pa/nm-hppah.h", accesses the variable
-     indirectly.  Mutter something rude about the HP merge.  */
+  /* NOTE: bje/2005-05-02: If you're looking at this code and thinking
+     that the variable stepped_after_stopped_by_watchpoint isn't used,
+     then you're wrong!  See remote.c:remote_stopped_data_address.  */
+
   int sw_single_step_trap_p = 0;
   int stopped_by_watchpoint = -1;      /* Mark as unknown.  */


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]

Re: PATCH comment in infrun.c

[Daniel Jacobowitz]

On Tue, May 03, 2005 at 09:41:49AM +1000, Ben Elliston wrote:
> > It needs updating, not removal; there's still a reference in remote.c.
> 
> Better?

OK, thanks.

> 
> Index: infrun.c
> ===================================================================
> RCS file: /home/bje/src-cvs/src/gdb/infrun.c,v
> retrieving revision 1.199
> diff -u -p -r1.199 infrun.c
> --- infrun.c    24 Feb 2005 13:51:32 -0000      1.199
> +++ infrun.c    2 May 2005 23:41:23 -0000
> @@ -1233,11 +1233,10 @@ int stepped_after_stopped_by_watchpoint;
>  void
>  handle_inferior_event (struct execution_control_state *ecs)
>  {
> -  /* NOTE: cagney/2003-03-28: If you're looking at this code and
> -     thinking that the variable stepped_after_stopped_by_watchpoint
> -     isn't used, then you're wrong!  The macro STOPPED_BY_WATCHPOINT,
> -     defined in the file "config/pa/nm-hppah.h", accesses the variable
> -     indirectly.  Mutter something rude about the HP merge.  */
> +  /* NOTE: bje/2005-05-02: If you're looking at this code and thinking
> +     that the variable stepped_after_stopped_by_watchpoint isn't used,
> +     then you're wrong!  See remote.c:remote_stopped_data_address.  */
> +
>    int sw_single_step_trap_p = 0;
>    int stopped_by_watchpoint = -1;      /* Mark as unknown.  */
> 



-- 
Daniel Jacobowitz
CodeSourcery, LLC