From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20298 invoked by alias); 2 May 2005 23:42:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20147 invoked from network); 2 May 2005 23:42:01 -0000 Received: from unknown (HELO ausmtp01.au.ibm.com) (202.81.18.186) by sourceware.org with SMTP; 2 May 2005 23:42:01 -0000 Received: from sd0112e0.au.ibm.com (d23rh903.au.ibm.com [202.81.18.201]) by ausmtp01.au.ibm.com (8.12.10/8.12.10) with ESMTP id j42NiJLU138570 for ; Tue, 3 May 2005 09:44:19 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.250.243]) by sd0112e0.au.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j42NijRo086946 for ; Tue, 3 May 2005 09:44:45 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.12.11/8.13.3) with ESMTP id j42Nfw5R018563 for ; Tue, 3 May 2005 09:41:59 +1000 Received: from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.190.163.12]) by d23av02.au.ibm.com (8.12.11/8.12.11) with ESMTP id j42NfwV5018558; Tue, 3 May 2005 09:41:58 +1000 Received: from [10.61.2.237] (haven.au.ibm.com [9.190.164.82]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.au.ibm.com (Postfix) with ESMTP id 0C4A47354D; Tue, 3 May 2005 09:42:10 +1000 (EST) Message-ID: <4276BABD.8030709@au.ibm.com> Date: Mon, 02 May 2005 23:42:00 -0000 From: Ben Elliston User-Agent: Debian Thunderbird 1.0.2 (X11/20050331) MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sourceware.org Subject: Re: PATCH comment in infrun.c References: <4275C1EB.9070705@au.ibm.com> <20050502123022.GA19811@nevyn.them.org> In-Reply-To: <20050502123022.GA19811@nevyn.them.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig48B17C92FF90CFC6849C261D" X-SW-Source: 2005-05/txt/msg00075.txt.bz2 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig48B17C92FF90CFC6849C261D Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 1159 > It needs updating, not removal; there's still a reference in remote.c. Better? Index: infrun.c =================================================================== RCS file: /home/bje/src-cvs/src/gdb/infrun.c,v retrieving revision 1.199 diff -u -p -r1.199 infrun.c --- infrun.c 24 Feb 2005 13:51:32 -0000 1.199 +++ infrun.c 2 May 2005 23:41:23 -0000 @@ -1233,11 +1233,10 @@ int stepped_after_stopped_by_watchpoint; void handle_inferior_event (struct execution_control_state *ecs) { - /* NOTE: cagney/2003-03-28: If you're looking at this code and - thinking that the variable stepped_after_stopped_by_watchpoint - isn't used, then you're wrong! The macro STOPPED_BY_WATCHPOINT, - defined in the file "config/pa/nm-hppah.h", accesses the variable - indirectly. Mutter something rude about the HP merge. */ + /* NOTE: bje/2005-05-02: If you're looking at this code and thinking + that the variable stepped_after_stopped_by_watchpoint isn't used, + then you're wrong! See remote.c:remote_stopped_data_address. */ + int sw_single_step_trap_p = 0; int stopped_by_watchpoint = -1; /* Mark as unknown. */ --------------enig48B17C92FF90CFC6849C261D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 256 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCdrrEMGpskFPkywkRAorkAKCcu2XiHGzUdLanzk2Vsdfig9PILgCfeNRV tjgFJHoP81iiecoppL/sW2g= =D9/H -----END PGP SIGNATURE----- --------------enig48B17C92FF90CFC6849C261D--