From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24559 invoked by alias); 2 May 2005 23:51:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24433 invoked from network); 2 May 2005 23:51:16 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 2 May 2005 23:51:16 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DSkh2-00077G-Be; Mon, 02 May 2005 19:51:16 -0400 Date: Mon, 02 May 2005 23:51:00 -0000 From: Daniel Jacobowitz To: Ben Elliston Cc: gdb-patches@sourceware.org Subject: Re: PATCH comment in infrun.c Message-ID: <20050502235116.GA27340@nevyn.them.org> Mail-Followup-To: Ben Elliston , gdb-patches@sourceware.org References: <4275C1EB.9070705@au.ibm.com> <20050502123022.GA19811@nevyn.them.org> <4276BABD.8030709@au.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4276BABD.8030709@au.ibm.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00076.txt.bz2 On Tue, May 03, 2005 at 09:41:49AM +1000, Ben Elliston wrote: > > It needs updating, not removal; there's still a reference in remote.c. > > Better? OK, thanks. > > Index: infrun.c > =================================================================== > RCS file: /home/bje/src-cvs/src/gdb/infrun.c,v > retrieving revision 1.199 > diff -u -p -r1.199 infrun.c > --- infrun.c 24 Feb 2005 13:51:32 -0000 1.199 > +++ infrun.c 2 May 2005 23:41:23 -0000 > @@ -1233,11 +1233,10 @@ int stepped_after_stopped_by_watchpoint; > void > handle_inferior_event (struct execution_control_state *ecs) > { > - /* NOTE: cagney/2003-03-28: If you're looking at this code and > - thinking that the variable stepped_after_stopped_by_watchpoint > - isn't used, then you're wrong! The macro STOPPED_BY_WATCHPOINT, > - defined in the file "config/pa/nm-hppah.h", accesses the variable > - indirectly. Mutter something rude about the HP merge. */ > + /* NOTE: bje/2005-05-02: If you're looking at this code and thinking > + that the variable stepped_after_stopped_by_watchpoint isn't used, > + then you're wrong! See remote.c:remote_stopped_data_address. */ > + > int sw_single_step_trap_p = 0; > int stopped_by_watchpoint = -1; /* Mark as unknown. */ > -- Daniel Jacobowitz CodeSourcery, LLC