[rfa] gdb.base/pc-fp.exp message

[rfa] gdb.base/pc-fp.exp message

[Felix Lee]

currently it says something like

    PASS: gdb.base/pc-fp.exp: get value of $fp (0xfefecec8)

the value is arbitrary, it doesn't seem useful to report it in
the test summary, and it adds noise to a diff of test summaries.
I'd like to delete the value.  ok?

gdb/testsuite/ChangeLog
2004-11-05  Felix Lee  <felix+log1@specifixinc.com>

        * gdb.base/pc-fp.exp (get_valueofx): Don't announce value.

--- gdb.base/pc-fp.exp.~1.2.~    2004-03-03 11:12:52.000000000 -0800
+++ gdb.base/pc-fp.exp   2004-11-05 23:23:18.000000000 -0800
@@ -62,7 +62,7 @@ proc get_valueofx { fmt exp default } {
     gdb_expect {
        -re "\\$\[0-9\]* = (0x\[0-9a-zA-Z\]+).*$gdb_prompt $" {
            set val $expect_out(1,string)
-           pass "get value of ${exp} ($val)"
+           pass "get value of ${exp}"
        }
        timeout {
            set val ${default}

Re: [rfa] gdb.base/pc-fp.exp message

[Andrew Cagney]

Felix Lee wrote:
> currently it says something like
> 
>     PASS: gdb.base/pc-fp.exp: get value of $fp (0xfefecec8)
> 
> the value is arbitrary, it doesn't seem useful to report it in
> the test summary, and it adds noise to a diff of test summaries.
> I'd like to delete the value.  ok?

If comparing test values, it's useful to strip out s/ ([^)]*)$// as that 
also removes things like "(timeout)" giving a better comparison.

However, here, which ever,

ok,
Andrew


> gdb/testsuite/ChangeLog
> 2004-11-05  Felix Lee  <felix+log1@specifixinc.com>
> 
>         * gdb.base/pc-fp.exp (get_valueofx): Don't announce value.
> 
> --- gdb.base/pc-fp.exp.~1.2.~    2004-03-03 11:12:52.000000000 -0800
> +++ gdb.base/pc-fp.exp   2004-11-05 23:23:18.000000000 -0800
> @@ -62,7 +62,7 @@ proc get_valueofx { fmt exp default } {
>      gdb_expect {
>         -re "\\$\[0-9\]* = (0x\[0-9a-zA-Z\]+).*$gdb_prompt $" {
>             set val $expect_out(1,string)
> -           pass "get value of ${exp} ($val)"
> +           pass "get value of ${exp}"
>         }
>         timeout {
>             set val ${default}
>