From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-36857-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 16654 invoked by alias); 11 Nov 2004 16:51:08 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 16578 invoked from network); 11 Nov 2004 16:50:55 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 11 Nov 2004 16:50:55 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iABGotcB005476
	for <gdb-patches@sources.redhat.com>; Thu, 11 Nov 2004 11:50:55 -0500
Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iABGotr02473;
	Thu, 11 Nov 2004 11:50:55 -0500
Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP id 29778129D8C;
	Thu, 11 Nov 2004 11:49:46 -0500 (EST)
Message-ID: <41939827.1070703@gnu.org>
Date: Thu, 11 Nov 2004 16:51:00 -0000
From: Andrew Cagney <cagney@gnu.org>
User-Agent: Mozilla Thunderbird 0.8 (X11/20041020)
MIME-Version: 1.0
To: Felix Lee <felix.1@canids.net>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa] gdb.base/pc-fp.exp message
References: <20041106073650.95B3A50346B@stray.canids>
In-Reply-To: <20041106073650.95B3A50346B@stray.canids>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004-11/txt/msg00231.txt.bz2

Felix Lee wrote:
> currently it says something like
> 
>     PASS: gdb.base/pc-fp.exp: get value of $fp (0xfefecec8)
> 
> the value is arbitrary, it doesn't seem useful to report it in
> the test summary, and it adds noise to a diff of test summaries.
> I'd like to delete the value.  ok?

If comparing test values, it's useful to strip out s/ ([^)]*)$// as that 
also removes things like "(timeout)" giving a better comparison.

However, here, which ever,

ok,
Andrew


> gdb/testsuite/ChangeLog
> 2004-11-05  Felix Lee  <felix+log1@specifixinc.com>
> 
>         * gdb.base/pc-fp.exp (get_valueofx): Don't announce value.
> 
> --- gdb.base/pc-fp.exp.~1.2.~    2004-03-03 11:12:52.000000000 -0800
> +++ gdb.base/pc-fp.exp   2004-11-05 23:23:18.000000000 -0800
> @@ -62,7 +62,7 @@ proc get_valueofx { fmt exp default } {
>      gdb_expect {
>         -re "\\$\[0-9\]* = (0x\[0-9a-zA-Z\]+).*$gdb_prompt $" {
>             set val $expect_out(1,string)
> -           pass "get value of ${exp} ($val)"
> +           pass "get value of ${exp}"
>         }
>         timeout {
>             set val ${default}
>