From: Andrew Cagney <cagney@gnu.org>
To: Felix Lee <felix.1@canids.net>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa] gdb.base/pc-fp.exp message
Date: Thu, 11 Nov 2004 16:51:00 -0000 [thread overview]
Message-ID: <41939827.1070703@gnu.org> (raw)
In-Reply-To: <20041106073650.95B3A50346B@stray.canids>
Felix Lee wrote:
> currently it says something like
>
> PASS: gdb.base/pc-fp.exp: get value of $fp (0xfefecec8)
>
> the value is arbitrary, it doesn't seem useful to report it in
> the test summary, and it adds noise to a diff of test summaries.
> I'd like to delete the value. ok?
If comparing test values, it's useful to strip out s/ ([^)]*)$// as that
also removes things like "(timeout)" giving a better comparison.
However, here, which ever,
ok,
Andrew
> gdb/testsuite/ChangeLog
> 2004-11-05 Felix Lee <felix+log1@specifixinc.com>
>
> * gdb.base/pc-fp.exp (get_valueofx): Don't announce value.
>
> --- gdb.base/pc-fp.exp.~1.2.~ 2004-03-03 11:12:52.000000000 -0800
> +++ gdb.base/pc-fp.exp 2004-11-05 23:23:18.000000000 -0800
> @@ -62,7 +62,7 @@ proc get_valueofx { fmt exp default } {
> gdb_expect {
> -re "\\$\[0-9\]* = (0x\[0-9a-zA-Z\]+).*$gdb_prompt $" {
> set val $expect_out(1,string)
> - pass "get value of ${exp} ($val)"
> + pass "get value of ${exp}"
> }
> timeout {
> set val ${default}
>
prev parent reply other threads:[~2004-11-11 16:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-06 7:36 Felix Lee
2004-11-11 16:51 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41939827.1070703@gnu.org \
--to=cagney@gnu.org \
--cc=felix.1@canids.net \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox