From: Andrew Cagney <cagney@gnu.org>
To: Michael Chastain <mec.gnu@mindspring.com>
Cc: drow@false.org, kettenis@chello.nl, gdb-patches@sources.redhat.com
Subject: Re: [testsuite] Kfail signals.exp failures
Date: Tue, 24 Aug 2004 22:35:00 -0000 [thread overview]
Message-ID: <412BC24B.9000304@gnu.org> (raw)
In-Reply-To: <4117A9EC.nail4LF31OFF4@mindspring.com>
> Perhaps we should move all the signals tests to a new subdirectory
> gdb.signal, and delegate someone else to be senior maintainer for
> that subdirectory? I would feel competent to be junior maintainer.
Well, you're actually doing your job to a tee. You made a decision
based on the best available information, and then when more information
came to light, revised the decision, and learn't from the experience :-)
(I've now posted fixes to both signals.exp and sigstep.exp)
As for a separate signals directory, this code is really testing
infrun.c (ya), and makes for some fundamental functionality (should have
been fixed working 10+ years ago), so I think still belongs in gdb.base.
Besides I've been naming all the files sig*.exp so that they are easy
to identify.
I think its better to reserve new directories for things that are
clearly separate -> stabs edge cases, dwarf edge cases, C++ lang stuff,
... We could too easily end up with a pedantic debate over which
directory a test belongs (...) :-)
> If we don't do that, then I'm going to try something new in gdb
> maintainership: delegation. I'll ask for 2 or 3 expert volunteers,
> and I'll approve a signals patch just when there's unanimous consent
> among the experts.
>
> And I've made a note to read up on signals tests.
Andrew
next prev parent reply other threads:[~2004-08-24 22:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-08 23:18 Daniel Jacobowitz
2004-08-09 7:00 ` Michael Chastain
2004-08-09 13:18 ` Daniel Jacobowitz
2004-08-09 7:46 ` Mark Kettenis
2004-08-09 13:11 ` Daniel Jacobowitz
2004-08-09 13:58 ` Andrew Cagney
2004-08-09 15:18 ` Daniel Jacobowitz
2004-08-09 16:17 ` Andrew Cagney
2004-08-09 16:44 ` Michael Chastain
2004-08-24 22:35 ` Andrew Cagney [this message]
2004-08-27 18:42 ` Mark Kettenis
2004-08-09 19:43 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=412BC24B.9000304@gnu.org \
--to=cagney@gnu.org \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
--cc=mec.gnu@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox