Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: mec.gnu@mindspring.com, Mark Kettenis <kettenis@chello.nl>,
	gdb-patches@sources.redhat.com
Subject: Re: [testsuite] Kfail signals.exp failures
Date: Mon, 09 Aug 2004 16:17:00 -0000	[thread overview]
Message-ID: <4117A36F.6050603@gnu.org> (raw)
In-Reply-To: <20040809151800.GA3986@nevyn.them.org>

> Yes, sigbpt.exp passes.
> 
> breakpoints/1702 is about the tendency of ia32 hardware to step two
> instructions over int $0x80.  That does not affect this test case; see
> the analysis in gdb/1738.

1702 is about broken kernels.  Both the s390 and PPC in question have a 
fixed kernel.  Since sigbpt.exp passes it soulds like your kernel is fixed?

> Please explain why the KFAILs are not correct, or why a new test is
> needed.  This is a bug in GDB; I analyzed the bug, filed a bug report,
> and marked the test which fails because of this bug as KFAILed to the
> PR.  Judging from the historical use of XFAIL, this is the precise bug
> that the test was written for.

Here's the original comment that went with the XFAILs:

# GDB yanks out the breakpoints to step over the breakpoint it
# stopped at, which means the breakpoint at handler is yanked.
# But if SOFTWARE_SINGLE_STEP_P, we won't get another chance to
# reinsert them (at least not with procfs, where we tell the kernel
# not to tell gdb about `pass' signals).  So the fix would appear to
# be to just yank that one breakpoint when we step over it.

and here's the new comment:

# This doesn't work correctly on platforms with hardware single
# step...

The test does pass on systems with working h/w single-step.  Can we fix 
the comment?

> My analysis does not explain why it passes on S/390, or on PPC.  If you
> want to, then remove the PPC kfail.

More anaysis and tests are needed here:

- something to cover "next" (next is different to continue)
- something to explain why i386 (what other systems did you test this 
on?) fails the continue (decr pc after break?)

can we do that?

Andrew



  reply	other threads:[~2004-08-09 16:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-08 23:18 Daniel Jacobowitz
2004-08-09  7:00 ` Michael Chastain
2004-08-09 13:18   ` Daniel Jacobowitz
2004-08-09  7:46 ` Mark Kettenis
2004-08-09 13:11   ` Daniel Jacobowitz
2004-08-09 13:58     ` Andrew Cagney
2004-08-09 15:18       ` Daniel Jacobowitz
2004-08-09 16:17         ` Andrew Cagney [this message]
2004-08-09 16:44       ` Michael Chastain
2004-08-24 22:35         ` Andrew Cagney
2004-08-27 18:42           ` Mark Kettenis
2004-08-09 19:43       ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4117A36F.6050603@gnu.org \
    --to=cagney@gnu.org \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@chello.nl \
    --cc=mec.gnu@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox