From: Andrew Cagney <cagney@gnu.org>
To: cgd@broadcom.com
Cc: gdb-patches@sources.redhat.com
Subject: [commit] s/mips{16,32}/mips_insn{16,32}; Was: [commit] Split MIPS unwinder three ways; partly
Date: Tue, 03 Aug 2004 01:15:00 -0000 [thread overview]
Message-ID: <410EE721.1020506@gnu.org> (raw)
In-Reply-To: <yov5oelts6jf.fsf@ldt-sj3-010.sj.broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 288 bytes --]
> At Mon, 02 Aug 2004 14:39:07 -0400, Andrew Cagney wrote:
>
>>> I'd rather have the code clearly scream its intent:
>>>
>>> mips_insn32_
>>> mips_insn16_
>
>
> that seems reasonable to me.
done. tempted by the chance to rewrite any of those unwinders from
scratch? :-)
Andrew
[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 8338 bytes --]
2004-08-02 Andrew Cagney <cagney@gnu.org>
* mips-tdep.c (mips_gdbarch_init, mips_insn16_frame_cache)
(mips_insn16_frame_this_id, mips_insn16_frame_prev_register)
(mips_insn16_frame_unwind, mips_insn16_frame_sniffer)
(mips_insn16_frame_base_address, mips_insn16_frame_base)
(mips_insn16_frame_base_sniffer, mips_insn32_frame_cache)
(mips_insn32_frame_this_id, mips_insn32_frame_prev_register)
(mips_insn32_frame_unwind, mips_insn32_frame_sniffer)
(mips_insn32_frame_base_address, mips_insn32_frame_base)
(mips_insn32_frame_base_sniffer): Replace mips16 / mips32 prefix
with mips_insn16 and mips_insn32.
Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.308
diff -p -u -r1.308 mips-tdep.c
--- mips-tdep.c 1 Aug 2004 18:47:58 -0000 1.308
+++ mips-tdep.c 3 Aug 2004 01:11:54 -0000
@@ -1778,8 +1778,12 @@ mips_mdebug_frame_base_sniffer (struct f
return NULL;
}
+/* Heuristic unwinder for 16-bit MIPS instruction set (aka MIPS16).
+ Procedures that use the 32-bit instruction set are handled by the
+ mips_insn32 unwinder. */
+
static struct mips_frame_cache *
-mips16_frame_cache (struct frame_info *next_frame, void **this_cache)
+mips_insn16_frame_cache (struct frame_info *next_frame, void **this_cache)
{
mips_extra_func_info_t proc_desc;
struct mips_frame_cache *cache;
@@ -1963,71 +1967,76 @@ mips16_frame_cache (struct frame_info *n
}
static void
-mips16_frame_this_id (struct frame_info *next_frame, void **this_cache,
+mips_insn16_frame_this_id (struct frame_info *next_frame, void **this_cache,
struct frame_id *this_id)
{
- struct mips_frame_cache *info = mips16_frame_cache (next_frame,
+ struct mips_frame_cache *info = mips_insn16_frame_cache (next_frame,
this_cache);
(*this_id) = frame_id_build (info->base, frame_func_unwind (next_frame));
}
static void
-mips16_frame_prev_register (struct frame_info *next_frame,
+mips_insn16_frame_prev_register (struct frame_info *next_frame,
void **this_cache,
int regnum, int *optimizedp,
enum lval_type *lvalp, CORE_ADDR *addrp,
int *realnump, void *valuep)
{
- struct mips_frame_cache *info = mips16_frame_cache (next_frame,
+ struct mips_frame_cache *info = mips_insn16_frame_cache (next_frame,
this_cache);
trad_frame_get_prev_register (next_frame, info->saved_regs, regnum,
optimizedp, lvalp, addrp, realnump, valuep);
}
-static const struct frame_unwind mips16_frame_unwind =
+static const struct frame_unwind mips_insn16_frame_unwind =
{
NORMAL_FRAME,
- mips16_frame_this_id,
- mips16_frame_prev_register
+ mips_insn16_frame_this_id,
+ mips_insn16_frame_prev_register
};
static const struct frame_unwind *
-mips16_frame_sniffer (struct frame_info *next_frame)
+mips_insn16_frame_sniffer (struct frame_info *next_frame)
{
CORE_ADDR pc = frame_pc_unwind (next_frame);
if (pc_is_mips16 (pc))
- return &mips16_frame_unwind;
+ return &mips_insn16_frame_unwind;
return NULL;
}
static CORE_ADDR
-mips16_frame_base_address (struct frame_info *next_frame,
+mips_insn16_frame_base_address (struct frame_info *next_frame,
void **this_cache)
{
- struct mips_frame_cache *info = mips16_frame_cache (next_frame,
+ struct mips_frame_cache *info = mips_insn16_frame_cache (next_frame,
this_cache);
return info->base;
}
-static const struct frame_base mips16_frame_base =
+static const struct frame_base mips_insn16_frame_base =
{
- &mips16_frame_unwind,
- mips16_frame_base_address,
- mips16_frame_base_address,
- mips16_frame_base_address
+ &mips_insn16_frame_unwind,
+ mips_insn16_frame_base_address,
+ mips_insn16_frame_base_address,
+ mips_insn16_frame_base_address
};
static const struct frame_base *
-mips16_frame_base_sniffer (struct frame_info *next_frame)
+mips_insn16_frame_base_sniffer (struct frame_info *next_frame)
{
- if (mips16_frame_sniffer (next_frame) != NULL)
- return &mips16_frame_base;
+ if (mips_insn16_frame_sniffer (next_frame) != NULL)
+ return &mips_insn16_frame_base;
else
return NULL;
}
+/* Heuristic unwinder for procedures using 32-bit instructions (covers
+ both 32-bit and 64-bit MIPS ISAs). Procedures using 16-bit
+ instructions (a.k.a. MIPS16) are handled by the mips_insn16
+ unwinder. */
+
static struct mips_frame_cache *
-mips32_frame_cache (struct frame_info *next_frame, void **this_cache)
+mips_insn32_frame_cache (struct frame_info *next_frame, void **this_cache)
{
mips_extra_func_info_t proc_desc;
struct mips_frame_cache *cache;
@@ -2211,65 +2220,65 @@ mips32_frame_cache (struct frame_info *n
}
static void
-mips32_frame_this_id (struct frame_info *next_frame, void **this_cache,
+mips_insn32_frame_this_id (struct frame_info *next_frame, void **this_cache,
struct frame_id *this_id)
{
- struct mips_frame_cache *info = mips32_frame_cache (next_frame,
+ struct mips_frame_cache *info = mips_insn32_frame_cache (next_frame,
this_cache);
(*this_id) = frame_id_build (info->base, frame_func_unwind (next_frame));
}
static void
-mips32_frame_prev_register (struct frame_info *next_frame,
+mips_insn32_frame_prev_register (struct frame_info *next_frame,
void **this_cache,
int regnum, int *optimizedp,
enum lval_type *lvalp, CORE_ADDR *addrp,
int *realnump, void *valuep)
{
- struct mips_frame_cache *info = mips32_frame_cache (next_frame,
+ struct mips_frame_cache *info = mips_insn32_frame_cache (next_frame,
this_cache);
trad_frame_get_prev_register (next_frame, info->saved_regs, regnum,
optimizedp, lvalp, addrp, realnump, valuep);
}
-static const struct frame_unwind mips32_frame_unwind =
+static const struct frame_unwind mips_insn32_frame_unwind =
{
NORMAL_FRAME,
- mips32_frame_this_id,
- mips32_frame_prev_register
+ mips_insn32_frame_this_id,
+ mips_insn32_frame_prev_register
};
static const struct frame_unwind *
-mips32_frame_sniffer (struct frame_info *next_frame)
+mips_insn32_frame_sniffer (struct frame_info *next_frame)
{
CORE_ADDR pc = frame_pc_unwind (next_frame);
if (! pc_is_mips16 (pc))
- return &mips32_frame_unwind;
+ return &mips_insn32_frame_unwind;
return NULL;
}
static CORE_ADDR
-mips32_frame_base_address (struct frame_info *next_frame,
+mips_insn32_frame_base_address (struct frame_info *next_frame,
void **this_cache)
{
- struct mips_frame_cache *info = mips32_frame_cache (next_frame,
+ struct mips_frame_cache *info = mips_insn32_frame_cache (next_frame,
this_cache);
return info->base;
}
-static const struct frame_base mips32_frame_base =
+static const struct frame_base mips_insn32_frame_base =
{
- &mips32_frame_unwind,
- mips32_frame_base_address,
- mips32_frame_base_address,
- mips32_frame_base_address
+ &mips_insn32_frame_unwind,
+ mips_insn32_frame_base_address,
+ mips_insn32_frame_base_address,
+ mips_insn32_frame_base_address
};
static const struct frame_base *
-mips32_frame_base_sniffer (struct frame_info *next_frame)
+mips_insn32_frame_base_sniffer (struct frame_info *next_frame)
{
- if (mips32_frame_sniffer (next_frame) != NULL)
- return &mips32_frame_base;
+ if (mips_insn32_frame_sniffer (next_frame) != NULL)
+ return &mips_insn32_frame_base;
else
return NULL;
}
@@ -6427,12 +6436,12 @@ mips_gdbarch_init (struct gdbarch_info i
/* Unwind the frame. */
frame_unwind_append_sniffer (gdbarch, mips_stub_frame_sniffer);
frame_unwind_append_sniffer (gdbarch, mips_mdebug_frame_sniffer);
- frame_unwind_append_sniffer (gdbarch, mips16_frame_sniffer);
- frame_unwind_append_sniffer (gdbarch, mips32_frame_sniffer);
+ frame_unwind_append_sniffer (gdbarch, mips_insn16_frame_sniffer);
+ frame_unwind_append_sniffer (gdbarch, mips_insn32_frame_sniffer);
frame_base_append_sniffer (gdbarch, mips_stub_frame_base_sniffer);
frame_base_append_sniffer (gdbarch, mips_mdebug_frame_base_sniffer);
- frame_base_append_sniffer (gdbarch, mips16_frame_base_sniffer);
- frame_base_append_sniffer (gdbarch, mips32_frame_base_sniffer);
+ frame_base_append_sniffer (gdbarch, mips_insn16_frame_base_sniffer);
+ frame_base_append_sniffer (gdbarch, mips_insn32_frame_base_sniffer);
return gdbarch;
}
prev parent reply other threads:[~2004-08-03 1:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-01 19:17 Andrew Cagney
[not found] ` <mailpost.1091387873.5834@news-sj1-1>
2004-08-02 16:14 ` cgd
2004-08-02 16:26 ` Andrew Cagney
[not found] ` <mailpost.1091464006.10693@news-sj1-1>
2004-08-02 16:43 ` cgd
2004-08-02 18:39 ` Andrew Cagney
2004-08-02 19:07 ` cgd
2004-08-03 1:15 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=410EE721.1020506@gnu.org \
--to=cagney@gnu.org \
--cc=cgd@broadcom.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox