From: Andrew Cagney <cagney@gnu.org>
To: cgd@broadcom.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit] Split MIPS unwinder three ways; partly
Date: Mon, 02 Aug 2004 18:39:00 -0000 [thread overview]
Message-ID: <410E8A4B.9080902@gnu.org> (raw)
In-Reply-To: <yov5wu0h1of6.fsf@ldt-sj3-010.sj.broadcom.com>
> At Mon, 2 Aug 2004 16:26:47 +0000 (UTC), "Andrew Cagney" wrote:
>
>>> True. mips_isa32?
>
>
> That may be *worse*, since mipsisa32 == "MIPS32" in bfd-speak.
>
> I don't know that it's important to make the names perfect, since this
> is internal implementation and isn't exposed.
>
> But in that case it should be documented that it refers to "mips ISAs
> with 32-bit instructions" (i.e., all but MIPS16).
I'd rather have the code clearly scream its intent:
mips_insn32_
mips_insn16_
? (otherwize in a few months we'll have someone unintentionally trying
to sneak code that handles 16-bit instruction into a 32-bit instruction
function).
Andrew
next prev parent reply other threads:[~2004-08-02 18:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-01 19:17 Andrew Cagney
[not found] ` <mailpost.1091387873.5834@news-sj1-1>
2004-08-02 16:14 ` cgd
2004-08-02 16:26 ` Andrew Cagney
[not found] ` <mailpost.1091464006.10693@news-sj1-1>
2004-08-02 16:43 ` cgd
2004-08-02 18:39 ` Andrew Cagney [this message]
2004-08-02 19:07 ` cgd
2004-08-03 1:15 ` [commit] s/mips{16,32}/mips_insn{16,32}; Was: " Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=410E8A4B.9080902@gnu.org \
--to=cagney@gnu.org \
--cc=cgd@broadcom.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox